Skip to content

Commit 7fc0bd2

Browse files
committed
fix: simplify validation checks in document and paragraph retrieval methods
1 parent 3d1ebad commit 7fc0bd2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

apps/knowledge/serializers/document.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,7 @@ def download_source_file(self):
606606
return FileSerializer.Operate(data={'id': file.id}).get(with_valid=True)
607607

608608
def one(self, with_valid=False):
609-
if with_valid:
610-
self.is_valid(raise_exception=True)
609+
self.is_valid(raise_exception=True)
611610
query_set = QuerySet(model=Document)
612611
query_set = query_set.filter(**{'id': self.data.get("document_id")})
613612
return native_search({

apps/knowledge/serializers/paragraph.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ def is_valid(self, *, raise_exception=False):
361361
raise AppApiException(500, _('Knowledge id does not exist'))
362362

363363
def get_query_set(self):
364+
self.is_valid()
364365
query_set = QuerySet(model=Paragraph)
365366
query_set = query_set.filter(
366367
**{'knowledge_id': self.data.get('knowledge_id'), 'document_id': self.data.get("document_id")})

0 commit comments

Comments
 (0)