Skip to content

Commit 936f117

Browse files
zhanweizhang7zhanweizhang7
committed
fix: Model permission of workspace manager
1 parent a772714 commit 936f117

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

‎apps/models_provider/views/model.py‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ class ModelSetting(APIView):
6666
request=ModelCreateAPI.get_request(),
6767
responses=ModelCreateAPI.get_response())
6868
@has_permissions(PermissionConstants.MODEL_CREATE.get_workspace_permission(),
69+
PermissionConstants.MODEL_EDIT.get_workspace_permission_workspace_manage_role(),
6970
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), RoleConstants.USER.get_workspace_role())
7071
@log(menu='model', operate='Create model',
7172
get_operation_object=lambda r, k: {'name': r.date.get('name')},
@@ -97,6 +98,7 @@ def post(self, request: Request, workspace_id: str):
9798
responses=ModelListResponse.get_response(),
9899
tags=[_('Model')]) # type: ignore
99100
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_permission(),
101+
PermissionConstants.MODEL_READ.get_workspace_permission_workspace_manage_role(),
100102
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), RoleConstants.USER.get_workspace_role())
101103
def get(self, request: Request, workspace_id: str):
102104
return result.success(
@@ -116,8 +118,9 @@ class Operate(APIView):
116118
parameters=GetModelApi.get_parameters(),
117119
responses=ModelEditApi.get_response(),
118120
tags=[_('Model')]) # type: ignore
119-
@has_permissions(PermissionConstants.MODEL_EDIT.get_workspace_permission(),
121+
@has_permissions(PermissionConstants.MODEL_EDIT.get_workspace_model_permission(),
120122
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
123+
PermissionConstants.MODEL_EDIT.get_workspace_permission_workspace_manage_role(),
121124
ViewPermission([RoleConstants.USER.get_workspace_role()],
122125
[PermissionConstants.MODEL.get_workspace_model_permission()],
123126
CompareConstants.AND),)
@@ -139,6 +142,7 @@ def put(self, request: Request, workspace_id, model_id: str):
139142
responses=DefaultModelResponse.get_response(),
140143
tags=[_('Model')]) # type: ignore
141144
@has_permissions(PermissionConstants.MODEL_DELETE.get_workspace_model_permission(),
145+
PermissionConstants.MODEL_DELETE.get_workspace_permission_workspace_manage_role(),
142146
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
143147
[PermissionConstants.MODEL.get_workspace_model_permission()],
144148
CompareConstants.AND),)
@@ -158,6 +162,7 @@ def delete(self, request: Request, workspace_id: str, model_id: str):
158162
responses=GetModelApi.get_response(),
159163
tags=[_('Model')]) # type: ignore
160164
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_model_permission(),
165+
PermissionConstants.MODEL_READ.get_workspace_permission_workspace_manage_role(),
161166
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
162167
[PermissionConstants.MODEL.get_workspace_model_permission()],
163168
CompareConstants.AND),)
@@ -178,6 +183,7 @@ class ModelParamsForm(APIView):
178183
responses=ProvideApi.ModelParamsForm.get_response(),
179184
tags=[_('Model')]) # type: ignore
180185
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_model_permission(),
186+
PermissionConstants.MODEL_READ.get_workspace_permission_workspace_manage_role(),
181187
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
182188
[PermissionConstants.MODEL.get_workspace_model_permission()],
183189
CompareConstants.AND),)
@@ -193,7 +199,8 @@ def get(self, request: Request, workspace_id: str, model_id: str):
193199
request=GetModelApi.get_request(),
194200
responses=ProvideApi.ModelParamsForm.get_response(),
195201
tags=[_('Model')]) # type: ignore
196-
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_model_permission(),
202+
@has_permissions(PermissionConstants.MODEL_EDIT.get_workspace_model_permission(),
203+
PermissionConstants.MODEL_EDIT.get_workspace_permission_workspace_manage_role(),
197204
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
198205
[PermissionConstants.MODEL.get_workspace_model_permission()],
199206
CompareConstants.AND),)
@@ -218,6 +225,7 @@ class ModelMeta(APIView):
218225
responses=GetModelApi.get_response(),
219226
tags=[_('Model')]) # type: ignore
220227
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_model_permission(),
228+
PermissionConstants.MODEL_READ.get_workspace_permission_workspace_manage_role(),
221229
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
222230
[PermissionConstants.MODEL.get_workspace_model_permission()],
223231
CompareConstants.AND),)
@@ -237,6 +245,7 @@ class PauseDownload(APIView):
237245
responses=DefaultModelResponse.get_response(),
238246
tags=[_('Model')]) # type: ignore
239247
@has_permissions(PermissionConstants.MODEL_CREATE.get_workspace_model_permission(),
248+
PermissionConstants.MODEL_CREATE.get_workspace_permission_workspace_manage_role(),
240249
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()],
241250
[PermissionConstants.MODEL.get_workspace_model_permission()],
242251
CompareConstants.AND),)
@@ -259,6 +268,7 @@ class WorkspaceSharedModelSetting(APIView):
259268
) # type: ignore
260269
@has_permissions(
261270
PermissionConstants.MODEL_READ.get_workspace_permission(),
271+
PermissionConstants.MODEL_READ.get_workspace_permission_workspace_manage_role(),
262272
RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
263273
RoleConstants.USER.get_workspace_role(),
264274
)

0 commit comments

Comments
 (0)