Skip to content

Commit e0075c3

Browse files
committed
refactor: update default icon path in tool models and related logic
1 parent bd8424a commit e0075c3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

apps/tools/migrations/0001_initial.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class Migration(migrations.Migration):
5757
('code', models.CharField(max_length=102400, verbose_name='python代码')),
5858
('input_field_list', models.JSONField(default=list, verbose_name='输入字段列表')),
5959
('init_field_list', models.JSONField(default=list, verbose_name='启动字段列表')),
60-
('icon', models.CharField(default='/ui/favicon.ico', max_length=256, verbose_name='工具库icon')),
60+
('icon', models.CharField(default='', max_length=256, verbose_name='工具库icon')),
6161
('is_active', models.BooleanField(default=True)),
6262
('scope', models.CharField(choices=[('SHARED', '共享'), ('WORKSPACE', '工作空间可用'), ('INTERNAL', '内置')], default='WORKSPACE', max_length=20, verbose_name='可用范围')),
6363
('tool_type', models.CharField(choices=[('INTERNAL', '内置'), ('CUSTOM', '自定义')], db_index=True, default='CUSTOM', max_length=20, verbose_name='工具类型')),

apps/tools/models/tool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class Tool(AppModelMixin):
4141
code = models.CharField(max_length=102400, verbose_name="python代码")
4242
input_field_list = models.JSONField(verbose_name="输入字段列表", default=list)
4343
init_field_list = models.JSONField(verbose_name="启动字段列表", default=list)
44-
icon = models.CharField(max_length=256, verbose_name="工具库icon", default="/ui/favicon.ico")
44+
icon = models.CharField(max_length=256, verbose_name="工具库icon", default="")
4545
is_active = models.BooleanField(default=True)
4646
scope = models.CharField(max_length=20, verbose_name='可用范围', choices=ToolScope.choices,
4747
default=ToolScope.WORKSPACE)

apps/tools/serializers/tool.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ def edit(self, instance, with_valid=True):
326326
def delete(self):
327327
self.is_valid(raise_exception=True)
328328
tool = QuerySet(Tool).filter(id=self.data.get('id')).first()
329-
if tool.template_id is None and tool.icon != '/ui/favicon.ico':
329+
if tool.template_id is None and tool.icon != '':
330330
QuerySet(File).filter(id=tool.icon.split('/')[-1]).delete()
331331
QuerySet(WorkspaceUserResourcePermission).filter(target=tool.id).delete()
332332
QuerySet(Tool).filter(id=self.data.get('id')).delete()
@@ -426,10 +426,10 @@ def edit(self, with_valid=True):
426426
if tool is None:
427427
raise AppApiException(500, _('Function does not exist'))
428428
# 删除旧的图片
429-
if tool.icon != '/ui/favicon.ico':
429+
if tool.icon != '':
430430
QuerySet(File).filter(id=tool.icon.split('/')[-1]).delete()
431431
if self.data.get('image') is None:
432-
tool.icon = '/ui/favicon.ico'
432+
tool.icon = ''
433433
else:
434434
meta = {
435435
'debug': False

0 commit comments

Comments
 (0)