Skip to content

Commit ecc2579

Browse files
committed
feat: update document and paragraph batch operations to use PUT method and rename classes for clarity
1 parent a04c2ef commit ecc2579

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

apps/knowledge/urls.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document', views.DocumentView.as_view()),
1212
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/split', views.DocumentView.Split.as_view()),
1313
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/split_pattern', views.DocumentView.SplitPattern.as_view()),
14-
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/batch', views.DocumentView.Batch.as_view()),
14+
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/batch_create', views.DocumentView.BatchCreate.as_view()),
15+
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/batch_sync', views.DocumentView.BatchSync.as_view()),
16+
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/batch_delete', views.DocumentView.BatchDelete.as_view()),
1517
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/web', views.WebDocumentView.as_view()),
1618
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/qa', views.QaDocumentView.as_view()),
1719
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/table', views.TableDocumentView.as_view()),
@@ -20,9 +22,9 @@
2022
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/sync', views.DocumentView.SyncWeb.as_view()),
2123
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/refresh', views.DocumentView.Refresh.as_view()),
2224
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/cancel_task', views.DocumentView.CancelTask.as_view()),
23-
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/cancel_task/batch', views.DocumentView.BatchCancelTask.as_view()),
25+
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/batch_cancel_task', views.DocumentView.BatchCancelTask.as_view()),
2426
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph', views.ParagraphView.as_view()),
25-
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph/batch', views.ParagraphView.Batch.as_view()),
27+
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph/batch_delete', views.ParagraphView.BatchDelete.as_view()),
2628
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph/<str:paragraph_id>', views.ParagraphView.Operate.as_view()),
2729
path('workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph/<str:paragraph_id>/problem', views.ParagraphView.Problem.as_view()),
2830
path( 'workspace/<str:workspace_id>/knowledge/<str:knowledge_id>/document/<str:document_id>/paragraph/<int:current_page>/<int:page_size>', views.ParagraphView.Page.as_view()),

apps/knowledge/views/document.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@ def put(self, request: Request, workspace_id: str, knowledge_id: str):
248248
'knowledge_id': knowledge_id, 'workspace_id': workspace_id}
249249
).batch_cancel(request.data))
250250

251-
class Batch(APIView):
251+
class BatchCreate(APIView):
252252
authentication_classes = [TokenAuth]
253253

254254
@extend_schema(
255-
methods=['POST'],
255+
methods=['PUT'],
256256
description=_('Create documents in batches'),
257257
summary=_('Create documents in batches'),
258258
operation_id=_('Create documents in batches'),
@@ -265,11 +265,14 @@ class Batch(APIView):
265265
PermissionConstants.DOCUMENT_CREATE.get_workspace_permission(),
266266
PermissionConstants.DOCUMENT_EDIT.get_workspace_permission(),
267267
])
268-
def post(self, request: Request, workspace_id: str, knowledge_id: str):
268+
def put(self, request: Request, workspace_id: str, knowledge_id: str):
269269
return result.success(DocumentSerializers.Batch(
270270
data={'knowledge_id': knowledge_id, 'workspace_id': workspace_id}
271271
).batch_save(request.data))
272272

273+
class BatchSync(APIView):
274+
authentication_classes = [TokenAuth]
275+
273276
@extend_schema(
274277
methods=['PUT'],
275278
description=_('Batch sync documents'),
@@ -289,8 +292,11 @@ def put(self, request: Request, workspace_id: str, knowledge_id: str):
289292
data={'knowledge_id': knowledge_id, 'workspace_id': workspace_id}
290293
).batch_sync(request.data))
291294

295+
class BatchDelete(APIView):
296+
authentication_classes = [TokenAuth]
297+
292298
@extend_schema(
293-
methods=['DELETE'],
299+
methods=['PUT'],
294300
description=_('Delete documents in batches'),
295301
summary=_('Delete documents in batches'),
296302
operation_id=_('Delete documents in batches'),
@@ -303,7 +309,7 @@ def put(self, request: Request, workspace_id: str, knowledge_id: str):
303309
PermissionConstants.DOCUMENT_CREATE.get_workspace_permission(),
304310
PermissionConstants.DOCUMENT_EDIT.get_workspace_permission(),
305311
])
306-
def delete(self, request: Request, workspace_id: str, knowledge_id: str):
312+
def put(self, request: Request, workspace_id: str, knowledge_id: str):
307313
return result.success(DocumentSerializers.Batch(
308314
data={'workspace_id': workspace_id, 'knowledge_id': knowledge_id}
309315
).batch_delete(request.data))

apps/knowledge/views/paragraph.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ def post(self, request: Request, workspace_id: str, knowledge_id: str, document_
5151
data={'workspace_id': workspace_id, 'knowledge_id': knowledge_id, 'document_id': document_id}
5252
).save(request.data))
5353

54-
class Batch(APIView):
54+
class BatchDelete(APIView):
5555
authentication_classes = [TokenAuth]
5656

5757
@extend_schema(
58-
methods=['DELETE'],
58+
methods=['PUT'],
5959
summary=_('Batch Paragraph'),
6060
description=_('Batch Paragraph'),
6161
operation_id=_('Batch Paragraph'),
@@ -65,7 +65,7 @@ class Batch(APIView):
6565
tags=[_('Knowledge Base/Documentation/Paragraph')]
6666
)
6767
@has_permissions(PermissionConstants.DOCUMENT_EDIT.get_workspace_permission())
68-
def delete(self, request: Request, workspace_id: str, knowledge_id: str, document_id: str):
68+
def put(self, request: Request, workspace_id: str, knowledge_id: str, document_id: str):
6969
return result.success(ParagraphSerializers.Batch(
7070
data={'workspace_id': workspace_id, 'knowledge_id': knowledge_id, 'document_id': document_id}
7171
).batch_delete(request.data))

0 commit comments

Comments
 (0)