Skip to content

Commit f05a4a6

Browse files
committed
feat: refactor response serializers for model parameters and lists
1 parent 4c38e8a commit f05a4a6

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

apps/models_provider/api/provide.py

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,21 @@ class ModelParamsFormSerializer(serializers.Serializer):
4646
props_info = serializers.DictField(required=False, label=_("props info"))
4747

4848

49+
class ModelParamsFormResponse(ResultSerializer):
50+
def get_data(self):
51+
return serializers.ListSerializer(child=ModelParamsFormSerializer())
52+
53+
54+
class ModelListResponse(ResultSerializer):
55+
def get_data(self):
56+
return serializers.ListSerializer(child=ModelListSerializer())
57+
58+
59+
class ProvideListResponse(ResultSerializer):
60+
def get_data(self):
61+
return serializers.ListSerializer(child=ProvideListSerializer())
62+
63+
4964
class ProvideApi(APIMixin):
5065
class ModelParamsForm(APIMixin):
5166
@staticmethod
@@ -73,11 +88,7 @@ def get_query_params_api():
7388

7489
@staticmethod
7590
def get_response():
76-
class ProvideListSerializer(ResultSerializer):
77-
def get_data(self):
78-
return serializers.ListSerializer(child=ModelParamsFormSerializer())
79-
80-
return ProvideListSerializer
91+
return ModelParamsFormResponse
8192

8293
class ModelList(APIMixin):
8394
@staticmethod
@@ -99,11 +110,7 @@ def get_query_params_api():
99110

100111
@staticmethod
101112
def get_response():
102-
class ProvideListSerializer(ResultSerializer):
103-
def get_data(self):
104-
return serializers.ListSerializer(child=ModelListSerializer())
105-
106-
return ProvideListSerializer
113+
return ModelListResponse
107114

108115
@staticmethod
109116
def get_response():
@@ -126,8 +133,4 @@ def get_query_params_api():
126133

127134
@staticmethod
128135
def get_response():
129-
class ProvideListResponse(ResultSerializer):
130-
def get_data(self):
131-
return serializers.ListSerializer(child=ProvideListSerializer())
132-
133136
return ProvideListResponse

apps/models_provider/views/model.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def get(self, request: Request, workspace_id: str, model_id: str):
118118
description=_('Save model parameter form'),
119119
operation_id=_('Save model parameter form'),
120120
parameters=GetModelApi.get_query_params_api(),
121+
request=GetModelApi.get_request(),
121122
responses=ProvideApi.ModelParamsForm.get_response(),
122123
tags=[_('Model')])
123124
@has_permissions(PermissionConstants.MODEL_READ.get_workspace_permission())
@@ -148,6 +149,7 @@ class PauseDownload(APIView):
148149
description=_('Pause model download'),
149150
operation_id=_('Pause model download'),
150151
parameters=GetModelApi.get_query_params_api(),
152+
request=GetModelApi.get_request(),
151153
responses=DefaultModelResponse.get_response(),
152154
tags=[_('Model')])
153155
@has_permissions(PermissionConstants.MODEL_CREATE.get_workspace_permission())

apps/models_provider/views/provide.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class ModelParamsForm(APIView):
7373

7474
@extend_schema(methods=['GET'],
7575
description=_('Get model default parameters'),
76-
operation_id=_('Get the model creation form'),
76+
operation_id=_('Get model default parameters'),
7777
parameters=ProvideApi.ModelParamsForm.get_query_params_api(),
7878
responses=ProvideApi.ModelParamsForm.get_response(),
7979
tags=[_('Model')])

0 commit comments

Comments
 (0)