Skip to content

fix: Fix import function lib permission#2395

Merged
liuruibin merged 1 commit intomainfrom
pr@main@fix_import
Feb 25, 2025
Merged

fix: Fix import function lib permission#2395
liuruibin merged 1 commit intomainfrom
pr@main@fix_import

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Fix import function lib permission --bug=1052409 --user=刘瑞斌 【函数库】导入一个原来是公有的函数,函数的权限依然是公有 https://www.tapd.cn/57709429/s/1658705

--bug=1052409 --user=刘瑞斌 【函数库】导入一个原来是公有的函数,函数的权限依然是公有 https://www.tapd.cn/57709429/s/1658705
@liuruibin liuruibin merged commit 5da758e into main Feb 25, 2025
4 checks passed
@liuruibin liuruibin deleted the pr@main@fix_import branch February 25, 2025 08:03
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has two main improvements:

  1. Changed permission_type to 'PRIVATE', which appears to be default value or required configuration that needs fixing. Ensure this setting aligns with expected permissions.

  2. Added a newline character after the closing triple dash --- in the diff comment for better formatting and readability, specifically between lines 273 and 276.

These changes should help standardize and ensure compliance with necessary project requirements.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 25, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 25, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants