Pr@main/user input

[wangdan-fit2cloud]

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

• Made sure tests are passing and test coverage is added if needed.
• Made sure commit message follow the rule of Conventional Commits specification.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code has several issues and optimizations that can be addressed:

1. Tabs Handling Issue:
   The v-model of the tabs does not update correctly when selected to "INTERNAL". The event handler tabChangeHandle() should ensure that selectUserId is reset to 'all' and searchValue is cleared when switching between tabs.

2. Raw Markdown Importing:
   The import statement for raw markdown files (...import.meta.glob('/fx/*/detail.md, ...)seems unnecessary as it will only work in development mode with a build environment. Consider usinguseFetch` or similar methods to dynamically retrieve data during runtime.

3. Code Duplicity:
   The code snippets around line 407 have duplicative logic where you check if init_fields exist before checking each field's default value. Simplify this condition to:

   if (
     res.data.init_params && // Check init_params first
     res.data.init_field_list &&
     [...]
     res.data.init_field_list.some(item => item.default_value)
   )

Here's the optimized version of the key segments affected by these issues:

<template>
  <!-- Template remains unchanged -->
</template>

<script setup lang='ts'>
import { ref, watch } from 'vue';
import type { Ref } from 'vue';

const functionName = ref('');
const selectUserId: Ref<string> = ref('') as Ref<string>;
const searchValue: Ref<string> = ref('');
// No need for const internalDesc

const { user } = useStore();

watch(
  () => selectUserId.value,
  newVal => {
    if (newVal !== 'all') {
      searchValue.value = ''; // Reset searchValue on userId change
    }
  },
  { immediate: true }
);

async function tabChangeHandle() {
  selectUserId.value = 'all'; // Always set selectUserId to 'all' when changing tabs
  searchValue.value = '';
}

// Rest of the script...

Optimized Code Summary:

• Removed raw markdown importing which may slow down production runs.
• Corrected handling of funcType changes to include resetting selectUserId to 'all'.
• Simplified logical checks for determining whether form fields have defaults.

These optimizations should improve both performance and usability.

[shaohuzhang1]

There are a few potential areas of improvement and corrections in the given code:

1. Undefined Check: The function toggleUserInput uses firsUserInput.value = false and showUserInput.value = false. Ensure that firsUserInput and showUserInput are properly initialized before being used.

2. Nullish Coalescing Operator: Consider using the nullish coalescing operator (??) when accessing properties like localStorage.getItem() to avoid errors if localStorage is not supported.

3. Stringify/Parse JSON Safely: When handling local storage, ensure that you parse and stringify objects safely by checking their validity. Use methods like JSON.parse(...) with defaults to prevent crashes.

4. Logical Order: In sendMessage function, there's an unnecessary nested condition inside the check for userFormRef.value?.checkInputParam(). Move it outside if necessary.

Here’s an updated version of the relevant parts of the code with some improvements:

function toggleUserInput() {
  if (userFormRef.value?.checkInputParam()) {
    firsUserInput.value ??= false;
    showUserInput.value ??= false;
  }
}

function sendMessage(val: string, other_params_data?: any, chat?: chatType) {
  const shouldProcessInput = !!userFormRef.value?.checkInputParam();

  // Show input if needed after processing
  if (!shouldProcessInput && isUserInput.value) {
    showUserInput.value = true;
  }

  if (!loading.value && props.applicationDetails?.name) {
    if (shouldProcessInput) {
      let userFormData = JSON.parse(localStorage.getItem(`${accessToken}userForm`) || '{}') ?? {};
      const newData = Object.fromEntries(
        Object.entries<Object>(form_data.value).filter(([key]) =>
          Object.prototype.hasOwnProperty.call(userFormData, key)
        )
      );
      localStorage.setItem(`${accessToken}userForm`, JSON.stringify(newData));
    }

    handleDebounceClick(val, other_params_data, chat);
  }
}

5. Additional Comments: Add comments where appropriate to explain complex logic or steps for future reference.

These changes aim to improve the robustness and readability of the代码 while maintaining its functionality.

[shaohuzhang1]

The provided code is generally well-written with proper imports, data declarations, watcher functions, and event emitters. However, there are a few minor improvements and optimizations that can be made:

1. Avoid using useRef for strings: Since params.accessToken will always return a string, you don't need to wrap it in ref. Use let or const directly.

2. Simplify watch, handle default values properly for showUderInput.

3. Remove redundant check in handleConfirmHandle:

// Original check for required input parameters
if (checkInputParam()) {
  emit('confirm');
}

If checkInputParam() already checks if the user has filled out the necessary fields and emits an error message if not, this can be removed since the logic might have been intended to prevent confirm action in such cases, but removing it doesn't alter the functionality significantly unless needed otherwise.

4. Remove unnecessary line breaks within template literals inside single quotes (''). The current format seems correct though, so no change is needed here.

By making these small adjustments, you could make the code cleaner and slightly more efficient. Keep up the good practices!