fix: Permission constants #3788
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| ) | ||
| RESOURCE_APPLICATION_EXPORT = Permission( | ||
| group=Group.SYSTEM_RES_APPLICATION, operate=Operate.EXPORT, role_list=[RoleConstants.ADMIN], | ||
| parent_group=[SystemGroup.RESOURCE_APPLICATION] |
There was a problem hiding this comment.
There seems to be an issue with the duplication of the GROUP field between "Import" and "Export" permissions in the same permission class. The current implementation includes both fields redundantly for each entry (e.g., group, operate, etc.). To fix this, only include unique groups once:
@@ -1213,6 +1212,6 @@ class PermissionConstants(Enum):
SYS_APP_DEBUG = Permission(
operate=Operate.DEBUG, role_list=[RoleAdmin],
parent_group=[SystemGroup.RESOURCE_APPLICATION]
- )This will clean up redundancy while maintaining consistent data structures within your codebase.
fix: Permission constants