-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Resource application permission #3793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @media only screen and (max-height: 680px) { | ||
| .workflow-debug-container { | ||
| height: 600px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code you provided is mostly clean but has some small formatting inconsistencies that could be improved for readability. Here are suggestions to address these:
Code Changes:
- Remove unnecessary spaces: Remove extra spaces before certain characters.
- Consistent indentation: Ensure consistent indentation throughout the file.
- Remove redundant comments: Some comments are not needed and can be removed or clarified.
Here's the corrected version of your code with these changes applied:
--- a/src/views/application/components/ApplicationDetails.vue
+++ b/src/views/application/components/ApplicationDetails.vue
@@ -5,23 +5,22 @@
<back-button @click="back"></back-button>
<h4 class="ellipsis" style="max-width: 300px" :title="detail?.name">{{ detail?.name }}</h4>
<div v-if="showHistory && disablePublic">
- <el-text type="info" class="ml-16 color-secondary"
- >{{ $t('views.applicationWorkflow.info.previewVersion') }}
- {{ currentVersion.name || datetimeFormat(currentVersion.update_time) }}</el-text
- >
+ <el-text type="info" class="ml-16 color-secondary">{{
+ $t('views.applicationWorkflow.info.previewVersion') }}
+ {{ currentVersion.name || datetimeFormat(currentVersion.update_time) }}</el-text>
</div>
- <el-text type="info" class="ml-16 color-secondary" v-else-if="saveTime"
- >{{ $t('views.applicationWorkflow.info.saveTime')
- }}{{ datetimeFormat(saveTime) }}</el-text
- >
+ <el-text type="info" class="ml-16 color-secondary" v-else-if="saveTime"> {{
+ $t('views.applicationWorkflow.info.saveTime')
+ }}{{ datetimeFormat(saveTime) }}</el-text>
</div>
<div v-if="showHistory && disablePublic">
<el-button type="primary" class="mr-8" @click="refreshVersion()">
{{ $t('views.applicationWorkflow.setting.restoreVersion') }}
</el-button>
<el-divider direction="vertical" />
<el-button text @click="closeHistory">
- <el-icon><Close /></el-icon>
+ <el-icon>
+ <Close />
+ </el-icon>
</el-button>
</div>
<div v-else>
@@ -30,8 +29,8 @@
</el-button>
<el-button @click="clickShowDebug" :disabled="showDebug">
<AppIcon iconName="app-debug-outlined" class="mr-4"></AppIcon>
- {{ $t('views.applicationWorkflow.setting.debug') }}</el-button
- >
+ {{ $t('views.applicationWorkflow.setting.debug') }}
+ </el-button>
<el-button @click="saveApplication(true)">
<AppIcon iconName="app-save-outlined" class="mr-4"></AppIcon>
{{ $t('common.save') }}
@@ -69,14 +70,7 @@ </div>
<!-- 下拉框 -->
<el-collapse-transition>
- <DropdownMenu
- :show="showPopover"
- :id="id"
- v-click-outside="clickoutside"
- @clickNodes="clickNodes"
- @onmousedown="onmousedown"
- :workflowRef="workflowRef"
- />
+ <DropdownMenu :show="showPopover" :id="id" v-click-outside="clickoutside" @clickNodes="clickNodes"
+ @onmousedown="onmousedown" :workflowRef="workflowRef" />
</el-collapse-transition>
<!-- 主画布 -->
<div class="workflow-main" ref="workflowMainRef">
@@ -91,12 +84,7 @@
<div class="flex-between">
<div class="flex align-center">
<div class="mr-12 ml-24 flex">
- <el-avatar
- v-if="isAppIcon(detail?.icon)"
- shape="square"
- :size="32"
- style="background: none"
- >
+ <el-avatar v-if="isAppIcon(detail?.icon)" shape="square" :size="32" style="background: none">
<img :src="resetUrl(detail?.icon)" alt="" />
</el-avatar>
<LogoIcon v-else height="32px" />
@@ -108,14 +96,14 @@
</div>
<div class="mr-16">
<el-button link @click="enlarge = !enlarge">
- <AppIcon
- :iconName="enlarge ? 'app-minify' : 'app-magnify'"
- class="color-secondary"
- style="font-size: 20px"
- ></AppIcon>
+ <AppIcon :iconName="enlarge ? 'app-minify' : 'app-magnify'" class="color-secondary" style="font-size: 20px">
+ </AppIcon>
</el-button>
<el-button link @click="showDebug = false">
- <el-icon :size="20" class="color-secondary"><Close /></el-icon>
+ <el-icon :size="20" class="color-secondary">
+ <Close />
+ </el-icon>
</el-button>
</div>
</div>
@@ -126,12 +114,8 @@
</div>
</el-collapse-transition>
<!-- 发布历史 -->
- <PublishHistory
- v-if="showHistory"
- @click="checkVersion"
- v-click-outside="clickoutsideHistory"
- @refreshVersion="refreshVersion"
- />
+ <PublishHistory v-if="showHistory" @click="checkVersion" v-click-outside="clickoutsideHistory"
+ @refreshVersion="refreshVersion" />
</div>
</template>
<script setup lang="ts">These changes remove any unnecessary spaces or redundancies, making the code more readable while maintaining its functionality.
feat: Resource application permission