Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Application creation time in reverse order

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

application_query_set = application_query_set.order_by("-create_time")

return {'folder_query_set': folder_query_set,
'application_query_set': application_query_set,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has an issue with the ordering. The order should be -update_time instead of -create_time. Therefore, change this line:

application_query_set = application_query_set.order_by("-create_time")

to

application_query_set = application_query_set.order_by("-update_time")

@shaohuzhang1 shaohuzhang1 merged commit 5d546c0 into v2 Sep 26, 2025
4 of 6 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_application branch September 26, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants