feat: Add SECRET_KEY environment variable settings #4235
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| SECRET_KEY = CONFIG.get("SECRET_KEY") or 'django-insecure-zm^1_^i5)3gp^&0io6zg72&z!a*d=9kf9o2%uft+27l)+t(#3e' | ||
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| DEBUG = CONFIG.get_debug() |
There was a problem hiding this comment.
Your code contains:
- An unnecessary call to
CONFIG.get_debug()when setting the SECRET_KEY, which might not be needed unless you have specific logic that depends on it.
Recommendation: Simplify the SECRET_KEY assignment by removing the conditional statement and just use CONFIG.get(). If DEBUG is needed elsewhere, ensure it is initialized appropriately before using it here.
feat: Add SECRET_KEY environment variable settings