Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: The component list in the loop body is missing variable aggregation --bug=1063074 --user=张展玮 【应用】循环体中组件列表缺少变量聚合 https://www.tapd.cn/62980211/s/1790996

--bug=1063074 --user=张展玮 【应用】循环体中组件列表缺少变量聚合 https://www.tapd.cn/62980211/s/1790996
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 29, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

list: [variableAssignNode, variableSplittingNode, parameterExtractionNode, variableAggregationNode],
},
{
label: t('views.applicationWorkflow.nodes.classify.other'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you provided has a minor issue. The parameterExtractionNode was incorrectly placed in the second node of the applicationLoopMenuNodes. It should be moved to the third position with the variableAggregationNode:

@@ -682,7 +682,7 @@ export const applicationLoopMenuNodes = [
 {
   label: t('views.applicationWorkflow.nodes.classify.dataProcessing', '数据处理'),
-  list: [variableAssignNode, variableSplittingNode, parameterExtractionNode],
+  list: [variableAssignNode, variableSplittingNode, variableAggregationNode, parameterExtractionNode],
 },
 {
   label: t('views.applicationWorkflow.nodes.classify.other'),

This ensures the correct order of nodes within each group for clarity and functionality.

@zhanweizhang7 zhanweizhang7 merged commit 855d2b2 into v2 Oct 29, 2025
4 of 6 checks passed
@zhanweizhang7 zhanweizhang7 deleted the pr@v2@fix_variable_aggregation_node_in_loop_node branch October 29, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants