Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: dependency package

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 6, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# 仅在scheduler中启动定时任务,dev local_model celery 不需要
if os.environ.get('ENABLE_SCHEDULER') == '1':
post_scheduler_handler()
post_scheduler_handler()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No significant issues were found in the provided code. The changes made to intercept and disable imports of popular machine learning libraries like torch could potentially be beneficial in environments where these should not be used due to security concerns, performance penalties, or dependency conflicts with other applications running on the same system.

However, please note that this change may require adjustments depending on whether you want certain parts of your Django app (e.g., using PyTorch modules directly during development) to work without restrictions imposed by this interceptor. You will also need ensure compatibility across different versions and configurations of software dependencies. Finally, consider documenting the impact of this change within your project documentation for users who might use it.

@shaohuzhang1 shaohuzhang1 merged commit 6df1e19 into v2 Nov 6, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_dependency branch November 6, 2025 12:17
liuruibin pushed a commit that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants