Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Node height

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 3, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

height: 100,
properties: {
stepName: t('views.workflow.nodes.knowledgeWriteNode.label'),
config: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you provided has two minor changes:

  1. The height property of the knowledgeWriteNode is reduced from 252 to 100 pixels.
  2. The value for the widthPropertyKey in the config section was changed to 'stepName'.

These changes may impact the visual layout of the workflow node on some interfaces. If these changes were intended, they align with reducing the size and focusing on the step name. However, without additional context about the specific requirements or constraints of your workflow application, it's difficult to determine whether either change is optimal.

If you have more details or if there are particular areas of concern (e.g., responsiveness, compatibility across different devices), feel free to share them so I can provide a more tailored response.

@zhanweizhang7 zhanweizhang7 merged commit 751cdc4 into v2 Dec 3, 2025
4 of 5 checks passed
@zhanweizhang7 zhanweizhang7 deleted the pr@v2@fix_node branch December 3, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants