Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: When there are user input parameters in the workflow, the data source setting information is cleared after returning to the previous step from the user input page

…ource setting information is cleared after returning to the previous step from the user input page
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

<keep-alive :key="key" :include="['DataSource', 'KnowledgeBase']">
<component
ref="ActionRef"
:is="ak[active]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your code, there are two potential issues that need to be addressed:

  1. Variable Name Consistency: The variable key is used with a capital letter (@Key in the template) but it should be consistently used as lower case (key in :key="key"). This consistency can help avoid syntax errors and improve legibility.

  2. Component Case Sensitivity: The component names 'DataSource', 'KnowledgeBase', and their references in ak[active] have inconsistent casing which might cause runtime issues depending on your environment’s case sensitivity settings.

To optimize the code:

  • Ensure you keep all instance variables consistent (e.g., using lowercase for key).
  • Maintain consistent naming conventions throughout the codebase.

Here's the corrected version of your code snippet:

<template>
  <el-container class="full-height">
    <el-header height="48px" @click.native.prevent.stop="">
      <!-- Header content -->
    </el-header>

    <el-main :style="{ maxHeight: 'calc(100vh - 96px)', overflow: 'auto' }">
      <keep-alive :key="key" :include="['dataSource', 'knowledge_base']">
        <component
          ref="actionRef"
          :is="ak[active]"
          :close-on-press-escape="false"
        />
      </keep-alive>
    </el-main>

    <el-footer>Footer</el-footer>
  </el-container>
</template>

<script>
export default {
  data() {
    return {
      isLoading: false,
      key: Math.random().toString(),
      ak: {},
      active: ''
    };
  },
  methods: {
    // Method definitions
  }
};
</script>

Make sure to adjust this example to fit within your project structure and integrate the rest of your logic accordingly.

@shaohuzhang1 shaohuzhang1 merged commit d835e24 into v2 Dec 5, 2025
3 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_workflow_upload branch December 5, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants