diff --git a/apps/tools/serializers/tool.py b/apps/tools/serializers/tool.py index 4275ef0c55b..d10aec7cccf 100644 --- a/apps/tools/serializers/tool.py +++ b/apps/tools/serializers/tool.py @@ -298,7 +298,6 @@ def is_one_valid(self, *, raise_exception=False): if get_authorized_tool: if not get_authorized_tool(QuerySet(Tool).filter(id=self.data.get('id')), workspace_id).exists(): raise AppApiException(500, _('Tool id does not exist')) - raise AppApiException(500, _('Tool id does not exist')) def is_valid(self, *, raise_exception=False): super().is_valid(raise_exception=True) diff --git a/apps/tools/views/tool.py b/apps/tools/views/tool.py index f25cea7bd7d..d707550579d 100644 --- a/apps/tools/views/tool.py +++ b/apps/tools/views/tool.py @@ -144,6 +144,9 @@ def put(self, request: Request, workspace_id: str, tool_id: str): PermissionConstants.TOOL_READ.get_workspace_tool_permission(), PermissionConstants.TOOL_READ.get_workspace_permission_workspace_manage_role(), RoleConstants.WORKSPACE_MANAGE.get_workspace_role(), + PermissionConstants.APPLICATION_READ.get_workspace_permission(), + PermissionConstants.APPLICATION_READ.get_workspace_permission_workspace_manage_role(), + RoleConstants.USER.get_workspace_role(), ViewPermission([RoleConstants.USER.get_workspace_role()], [PermissionConstants.TOOL.get_workspace_tool_permission()], CompareConstants.AND),