clean up example, update error msg for limit and ensure we are checking for bytes not characaters on invocation size check

Author: MOmarMiraj

example/example.py

@@ -7,8 +7,6 @@
 # [developer-docs.sdk.python.sdk-import]-end
 from cryptography.hazmat.primitives.asymmetric import rsa
 from cryptography.hazmat.primitives import serialization
-from cryptography.hazmat.primitives import hashes
-from cryptography.hazmat.primitives.asymmetric import padding
 
 async def main():
     # [developer-docs.sdk.python.client-initialization]-start
@@ -267,6 +265,7 @@ async def create_ssh_key_item(client: Client):
     print(created_item.fields[0].details.content.fingerprint)
     print(created_item.fields[0].details.content.key_type)
     # [developer-docs.sdk.python.create-sshkey-item]-end
+    await client.items.delete(created_item.vault_id, created_item.id)
 
 
 async def create_and_replace_document_item(client: Client):
@@ -276,20 +275,9 @@ async def create_and_replace_document_item(client: Client):
         title="Document Item Created with Python SDK",
         category=ItemCategory.DOCUMENT,
         vault_id="7turaasywpymt3jecxoxk5roli",
-        fields=[
-            ItemField(
-                id="onetimepassword",
-                title="one-time-password",
-                field_type=ItemFieldType.TOTP,
-                section_id="totpsection",
-                value="otpauth://totp/my-example-otp?secret=jncrjgbdjnrncbjsr&issuer=1Password",
-            ),
-        ],
         sections=[
             ItemSection(id="", title=""),
-            ItemSection(id="totpsection", title=""),
         ],
-        tags=["test tag 1", "test tag 2"],
         document=DocumentCreateParams(name="file.txt",content=Path("./example/file.txt").read_bytes())
     )
     created_item = await client.items.create(to_create)
@@ -307,6 +295,9 @@ async def create_and_replace_document_item(client: Client):
 
     print(content)
 
+    await client.items.delete(replaced_item.vault_id, replaced_item.id)
+
+
 async def create_attach_and_delete_file_field_item(client: Client):
     # [developer-docs.sdk.python.create-item-with-file-field]-start
     # Create a File Field Item
@@ -331,7 +322,6 @@ async def create_attach_and_delete_file_field_item(client: Client):
         sections=[
             ItemSection(id="", title=""),
         ],
-        tags=["test tag 1", "test tag 2"],
         files=[FileCreateParams(name="file.txt",content=Path("./example/file.txt").read_bytes(),sectionId="",fieldId="file_field")]
     )
 
@@ -345,10 +335,12 @@ async def create_attach_and_delete_file_field_item(client: Client):
 
     # [developer-docs.sdk.python.delete-file-field-item]-start
     # Delete a file field from an item
-    deleted_item = await client.items.files.delete(attached_item, attached_item.files[0].section_id, attached_item.files[0].field_id)
+    deleted_file_item = await client.items.files.delete(attached_item, attached_item.files[0].section_id, attached_item.files[0].field_id)
     # [developer-docs.sdk.python.delete-file-field-item]-end
 
-    print(len(deleted_item.files))
+    print(len(deleted_file_item.files))
+
+    await client.items.delete(deleted_file_item.vault_id, deleted_file_item.id)
 
 if __name__ == "__main__":
     asyncio.run(main())

src/onepassword/core.py

@@ -5,7 +5,7 @@
 
 # In empirical tests, we determined that maximum message size that can cross the FFI boundary 
 # is ~128MB. Past this limit, FFI will throw an error and the program will crash.
-# We set the limit to 50MB to be safe and consistent with the other SDKs, to be reconsidered upon further testing
+# We set the limit to 50MB to be safe and consistent with the other SDKs (where this limit is 64MB), to be reconsidered upon further testing
 MESSAGE_LIMIT = 50 * 1024 * 1024
 
 machine_arch = platform.machine().lower()
@@ -31,9 +31,9 @@ async def _init_client(client_config):
 # Invoke calls specified business logic from the SDK core.
 async def _invoke(invoke_config):
     serialized_config = json.dumps(invoke_config)
-    if len(serialized_config) > MESSAGE_LIMIT:
+    if len(serialized_config.encode()) > MESSAGE_LIMIT:
         raise ValueError(
-            f"Message size exceeds the limit of {MESSAGE_LIMIT} bytes.")
+            f"message size exceeds the limit of {MESSAGE_LIMIT} bytes, please contact 1Password at [email protected] or https://developer.1password.com/joinslack if you need help.")
     try:
         return await core.invoke(serialized_config)
     except Exception as e:
@@ -43,7 +43,7 @@ async def _invoke(invoke_config):
 # Invoke calls specified business logic from the SDK core.
 def _invoke_sync(invoke_config):
     serialized_config = json.dumps(invoke_config)
-    if len(serialized_config) > MESSAGE_LIMIT:
+    if len(serialized_config.encode()) > MESSAGE_LIMIT:
         raise ValueError(
             f"Message size exceeds the limit of {MESSAGE_LIMIT} bytes.")
     try:

src/release/RELEASE-NOTES

@@ -10,4 +10,4 @@
 - **Read SSH keys in Open SSH format**: You can now use a secret reference to fetch a private key in OpenSSH format. For example: `op://vault/<SSH item>/private key?ssh-format=openssh`
 - **Support for more item field types**: You can now create, retrieve, and edit items containing SSH keys, Month-Year and Menu-type fields using the SDK.
 - **Read more field types using secret references**: You can now resolve secret references that point to information stored in Date, Month/Year, Address, and Reference field types.
-- **Improved error messages**: The error messages returned by the SDK were improved to be more clear and actionable.
+- **Improved error messages**: The error messages returned by the SDK were improved to be more clear and actionable.