Skip to content

Commit 871fc7f

Browse files
authored
Merge pull request #40 from ajyey/feature/default-request-library
Updates default request library
2 parents 7ca51b5 + 4f307bf commit 871fc7f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/onepassword/defaults.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
SDK_VERSION = "0010100"
55
DEFAULT_INTEGRATION_NAME = "Unknown"
66
DEFAULT_INTEGRATION_VERSION = "Unknown"
7-
DEFAULT_REQUEST_LIBRARY = "net/http"
7+
DEFAULT_REQUEST_LIBRARY = "reqwest"
8+
DEFAULT_REQUEST_LIBRARY_VERSION = "0.11.24"
89
DEFAULT_OS_VERSION = "0.0.0"
910

1011

@@ -17,7 +18,7 @@ def new_default_config(auth, integration_name, integration_version):
1718
"integrationName": integration_name,
1819
"integrationVersion": integration_version,
1920
"requestLibraryName": DEFAULT_REQUEST_LIBRARY,
20-
"requestLibraryVersion": platform.python_version(),
21+
"requestLibraryVersion": DEFAULT_REQUEST_LIBRARY_VERSION,
2122
"os": platform.system().lower(),
2223
"osVersion": DEFAULT_OS_VERSION,
2324
"architecture": platform.machine(),

src/onepassword/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def test_good_new_onepassword_default_config():
102102
config["integrationVersion"] == onepassword_defaults.DEFAULT_INTEGRATION_VERSION
103103
)
104104
assert config["requestLibraryName"] == onepassword_defaults.DEFAULT_REQUEST_LIBRARY
105-
assert config["requestLibraryVersion"] == platform.python_version()
105+
assert config["requestLibraryVersion"] == onepassword_defaults.DEFAULT_REQUEST_LIBRARY_VERSION
106106
assert config["os"] == platform.system().lower()
107107
assert config["osVersion"] == onepassword_defaults.DEFAULT_OS_VERSION
108108
assert config["architecture"] == platform.machine()

0 commit comments

Comments
 (0)