rename credential name to be more clear

Author: wongle

plugins/akamai/akamai.go

@@ -26,7 +26,7 @@ func AkamaiCLI() schema.Executable {
 		),
 		Uses: []schema.CredentialUsage{
 			{
-				Name: credname.Credentials,
+				Name: credname.APIClientCredentials,
 			},
 		},
 	}

plugins/akamai/credentials.go plugins/akamai/api_client_credentials.goplugins/akamai/credentials.go renamed to plugins/akamai/api_client_credentials.go

@@ -11,9 +11,9 @@ import (
 	"github.com/1Password/shell-plugins/sdk/schema/fieldname"
 )
 
-func Credentials() schema.CredentialType {
+func APIClientCredentials() schema.CredentialType {
 	return schema.CredentialType{
-		Name:          credname.Credentials,
+		Name:          credname.APIClientCredentials,
 		DocsURL:       sdk.URL("https://techdocs.akamai.com/developer/docs/set-up-authentication-credentials"),
 		ManagementURL: sdk.URL("https://control.akamai.com/apps/identity-management/#/tabs/users/list"),
 		Fields: []schema.CredentialField{

plugins/akamai/credentials_test.go …ns/akamai/api_client_credentials_test.goplugins/akamai/credentials_test.go renamed to plugins/akamai/api_client_credentials_test.go plugins/akamai/credentials_test.go renamed to plugins/akamai/api_client_credentials_test.go

@@ -8,8 +8,8 @@ import (
 	"github.com/1Password/shell-plugins/sdk/schema/fieldname"
 )
 
-func TestCredentialsProvisioner(t *testing.T) {
-	plugintest.TestProvisioner(t, Credentials().DefaultProvisioner, map[string]plugintest.ProvisionCase{
+func TestAPIClientCredentialsProvisioner(t *testing.T) {
+	plugintest.TestProvisioner(t, APIClientCredentials().DefaultProvisioner, map[string]plugintest.ProvisionCase{
 		"default": {
 			ItemFields: map[sdk.FieldName]string{
 				fieldname.ClientSecret: "abcdE23FNkBxy456z25qx9Yp5CPUxlEfQeTDkfh4QA=I",
@@ -27,8 +27,8 @@ func TestCredentialsProvisioner(t *testing.T) {
 	})
 }
 
-func TestCredentialsImporter(t *testing.T) {
-	plugintest.TestImporter(t, Credentials().Importer, map[string]plugintest.ImportCase{
+func TestAPIClientCredentialsImporter(t *testing.T) {
+	plugintest.TestImporter(t, APIClientCredentials().Importer, map[string]plugintest.ImportCase{
 		"config file with single credential": {
 			Files: map[string]string{
 				"~/.edgerc": plugintest.LoadFixture(t, ".edgerc-single"),

plugins/akamai/plugin.go

@@ -13,7 +13,7 @@ func New() schema.Plugin {
 			Homepage: sdk.URL("https://akamai.com"),
 		},
 		Credentials: []schema.CredentialType{
-			Credentials(),
+			APIClientCredentials(),
 		},
 		Executables: []schema.Executable{
 			AkamaiCLI(),

sdk/schema/credname/names.go

@@ -4,26 +4,28 @@ import "github.com/1Password/shell-plugins/sdk"
 
 // Credential type names.
 const (
-	APIKey              = sdk.CredentialName("API Key")
-	APIToken            = sdk.CredentialName("API Token")
-	AccessKey           = sdk.CredentialName("Access Key")
-	AccessToken         = sdk.CredentialName("Access Token")
-	AppPassword         = sdk.CredentialName("App Password")
-	AppToken            = sdk.CredentialName("App Token")
-	AuthToken           = sdk.CredentialName("Auth Token")
-	CLIToken            = sdk.CredentialName("CLI Token")
-	Credential          = sdk.CredentialName("Credential")
-	Credentials         = sdk.CredentialName("Credentials")
-	DatabaseCredentials = sdk.CredentialName("Database Credentials")
-	LoginDetails        = sdk.CredentialName("Login Details")
-	PersonalAPIToken    = sdk.CredentialName("Personal API Token")
-	PersonalAccessToken = sdk.CredentialName("Personal Access Token")
-	RegistryCredentials = sdk.CredentialName("Registry Credentials")
-	SecretKey           = sdk.CredentialName("Secret Key")
+	APIClientCredentials = sdk.CredentialName("API Client Credentials")
+	APIKey               = sdk.CredentialName("API Key")
+	APIToken             = sdk.CredentialName("API Token")
+	AccessKey            = sdk.CredentialName("Access Key")
+	AccessToken          = sdk.CredentialName("Access Token")
+	AppPassword          = sdk.CredentialName("App Password")
+	AppToken             = sdk.CredentialName("App Token")
+	AuthToken            = sdk.CredentialName("Auth Token")
+	CLIToken             = sdk.CredentialName("CLI Token")
+	Credential           = sdk.CredentialName("Credential")
+	Credentials          = sdk.CredentialName("Credentials")
+	DatabaseCredentials  = sdk.CredentialName("Database Credentials")
+	LoginDetails         = sdk.CredentialName("Login Details")
+	PersonalAPIToken     = sdk.CredentialName("Personal API Token")
+	PersonalAccessToken  = sdk.CredentialName("Personal Access Token")
+	RegistryCredentials  = sdk.CredentialName("Registry Credentials")
+	SecretKey            = sdk.CredentialName("Secret Key")
 )
 
 func ListAll() []sdk.CredentialName {
 	return []sdk.CredentialName{
+		APIClientCredentials,
 		APIKey,
 		APIToken,
 		AccessKey,