Implement todos

Author: simonrw

plugins/localstack/api_key.go

@@ -1,8 +1,6 @@
 package localstack
 
 import (
-	"context"
-
 	"github.com/1Password/shell-plugins/sdk"
 	"github.com/1Password/shell-plugins/sdk/importer"
 	"github.com/1Password/shell-plugins/sdk/provision"
@@ -14,8 +12,8 @@ import (
 func APIKey() schema.CredentialType {
 	return schema.CredentialType{
 		Name:          credname.APIKey,
-		DocsURL:       sdk.URL("https://localstack.com/docs/api_key"), // TODO: Replace with actual URL
-		ManagementURL: sdk.URL("https://console.localstack.com/user/security/tokens"), // TODO: Replace with actual URL
+		DocsURL:       sdk.URL("https://docs.localstack.cloud/getting-started/api-key/"),
+		ManagementURL: sdk.URL("https://app.localstack.cloud/account/apikeys"),
 		Fields: []schema.CredentialField{
 			{
 				Name:                fieldname.APIKey,
@@ -34,37 +32,9 @@ func APIKey() schema.CredentialType {
 		DefaultProvisioner: provision.EnvVars(defaultEnvVarMapping),
 		Importer: importer.TryAll(
 			importer.TryEnvVarPair(defaultEnvVarMapping),
-			TryLocalStackConfigFile(),
 		)}
 }
 
 var defaultEnvVarMapping = map[string]sdk.FieldName{
-	"LOCALSTACK_API_KEY": fieldname.APIKey, // TODO: Check if this is correct
-}
-
-// TODO: Check if the platform stores the API Key in a local config file, and if so,
-// implement the function below to add support for importing it.
-func TryLocalStackConfigFile() sdk.Importer {
-	return importer.TryFile("~/path/to/config/file.yml", func(ctx context.Context, contents importer.FileContents, in sdk.ImportInput, out *sdk.ImportAttempt) {
-		// var config Config
-		// if err := contents.ToYAML(&config); err != nil {
-		// 	out.AddError(err)
-		// 	return
-		// }
-
-		// if config.APIKey == "" {
-		// 	return
-		// }
-
-		// out.AddCandidate(sdk.ImportCandidate{
-		// 	Fields: map[sdk.FieldName]string{
-		// 		fieldname.APIKey: config.APIKey,
-		// 	},
-		// })
-	})
+	"LOCALSTACK_API_KEY": fieldname.APIKey,
 }
-
-// TODO: Implement the config file schema
-// type Config struct {
-//	APIKey string
-// }

plugins/localstack/api_key_test.go

@@ -11,7 +11,7 @@ import (
 func TestAPIKeyProvisioner(t *testing.T) {
 	plugintest.TestProvisioner(t, APIKey().DefaultProvisioner, map[string]plugintest.ProvisionCase{
 		"default": {
-			ItemFields: map[sdk.FieldName]string{ // TODO: Check if this is correct
+			ItemFields: map[sdk.FieldName]string{
 				fieldname.APIKey: "SzCEXAMPLE",
 			},
 			ExpectedOutput: sdk.ProvisionOutput{
@@ -26,7 +26,7 @@ func TestAPIKeyProvisioner(t *testing.T) {
 func TestAPIKeyImporter(t *testing.T) {
 	plugintest.TestImporter(t, APIKey().Importer, map[string]plugintest.ImportCase{
 		"environment": {
-			Environment: map[string]string{ // TODO: Check if this is correct
+			Environment: map[string]string{
 				"LOCALSTACK_API_KEY": "SzCEXAMPLE",
 			},
 			ExpectedCandidates: []sdk.ImportCandidate{
@@ -37,19 +37,5 @@ func TestAPIKeyImporter(t *testing.T) {
 				},
 			},
 		},
-		// TODO: If you implemented a config file importer, add a test file example in localstack/test-fixtures
-		// and fill the necessary details in the test template below.
-		"config file": {
-			Files: map[string]string{
-				// "~/path/to/config.yml": plugintest.LoadFixture(t, "config.yml"),
-			},
-			ExpectedCandidates: []sdk.ImportCandidate{
-			// 	{
-			// 		Fields: map[sdk.FieldName]string{
-			// 			fieldname.Token: "SzCEXAMPLE",
-			// 		},
-			// 	},
-			},
-		},
 	})
 }

plugins/localstack/localstack.go

@@ -9,9 +9,9 @@ import (
 
 func LocalStackCLI() schema.Executable {
 	return schema.Executable{
-		Name:      "LocalStack CLI", // TODO: Check if this is correct
+		Name:      "LocalStack CLI",
 		Runs:      []string{"localstack"},
-		DocsURL:   sdk.URL("https://localstack.com/docs/cli"), // TODO: Replace with actual URL
+		DocsURL:   sdk.URL("https://docs.localstack.cloud/getting-started/installation/#localstack-cli"),
 		NeedsAuth: needsauth.IfAll(
 			needsauth.NotForHelpOrVersion(),
 			needsauth.NotWithoutArgs(),

plugins/localstack/plugin.go

@@ -10,7 +10,7 @@ func New() schema.Plugin {
 		Name: "localstack",
 		Platform: schema.PlatformInfo{
 			Name:     "LocalStack",
-			Homepage: sdk.URL("https://localstack.com"), // TODO: Check if this is correct
+			Homepage: sdk.URL("https://localstack.cloud"),
 		},
 		Credentials: []schema.CredentialType{
 			APIKey(),