Re commited Vertica

Author: parthiv11

plugins/vertica/database_credentials.go

@@ -1,8 +1,6 @@
 package vertica
 
 import (
-	"context"
-
 	"github.com/1Password/shell-plugins/sdk"
 	"github.com/1Password/shell-plugins/sdk/importer"
 	"github.com/1Password/shell-plugins/sdk/provision"
@@ -13,9 +11,8 @@ import (
 
 func DatabaseCredentials() schema.CredentialType {
 	return schema.CredentialType{
-		Name:          credname.DatabaseCredentials,
-		DocsURL:       sdk.URL("https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ConnectingToVertica/vsql/Install/InstallingTheVsqlClient.htm"), 
-		ManagementURL: sdk.URL("https://www.vertica.com/try/"), 
+		Name:    credname.DatabaseCredentials,
+		DocsURL: sdk.URL("https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/AdministratorsGuide/DBUsersAndPrivileges/Users/CreatingADatabaseUser.htm"),
 		Fields: []schema.CredentialField{
 			{
 				Name:                fieldname.Host,
@@ -30,7 +27,6 @@ func DatabaseCredentials() schema.CredentialType {
 			{
 				Name:                fieldname.Username,
 				MarkdownDescription: "Vertica user to authenticate as.",
-				Optional:            true,
 			},
 			{
 				Name:                fieldname.Password,
@@ -40,18 +36,16 @@ func DatabaseCredentials() schema.CredentialType {
 			{
 				Name:                fieldname.Database,
 				MarkdownDescription: "Database name to connect to.",
-				Optional:            true,
 			},
 		},
 		DefaultProvisioner: provision.EnvVars(defaultEnvVarMapping),
-		Importer: importer.TryAllimporter.TryEnvVarPair(defaultEnvVarMapping)}
+		Importer:           importer.TryEnvVarPair(defaultEnvVarMapping)}
 }
 
 var defaultEnvVarMapping = map[string]sdk.FieldName{
-	"VSQL_USER": fieldname.Username, 
-	"VSQL_PASSWORD": fieldname.Password, 
-	"VSQL_HOST": fieldname.Host, 
-	"VSQL_PORT": fieldname.Port, 
-	"VSQL_DATABASE": fieldname.Database, 
+	"VSQL_USER":     fieldname.Username,
+	"VSQL_PASSWORD": fieldname.Password,
+	"VSQL_HOST":     fieldname.Host,
+	"VSQL_PORT":     fieldname.Port,
+	"VSQL_DATABASE": fieldname.Database,
 }
-

plugins/vertica/database_credentials_test.go

@@ -2,31 +2,56 @@ package vertica
 
 import (
 	"testing"
-	
+
 	"github.com/1Password/shell-plugins/sdk"
 	"github.com/1Password/shell-plugins/sdk/plugintest"
 	"github.com/1Password/shell-plugins/sdk/schema/fieldname"
 )
-	
+
 func TestDatabaseCredentialsProvisioner(t *testing.T) {
 	plugintest.TestProvisioner(t, DatabaseCredentials().DefaultProvisioner, map[string]plugintest.ProvisionCase{
 		"default": {
 			ItemFields: map[sdk.FieldName]string{
-				fieldname.User: "vertica",
-				fieldname.Password: "",
-				fieldname.Host: "localhost",
-				fieldname.Port: "5433",
+				fieldname.Username: "vertica",
+				fieldname.Password: "Il0v3y04",
+				fieldname.Host:     "localhost",
+				fieldname.Port:     "5433",
 				fieldname.Database: "VMart",
 			},
 			ExpectedOutput: sdk.ProvisionOutput{
 				Environment: map[string]string{
-					"VSQL_USER": "vertica", 
-					"VSQL_PASSWORD": "", 
-					"VSQL_HOST": "localhost", 
-					"VSQL_PORT": "5433", 
+					"VSQL_USER":     "vertica",
+					"VSQL_PASSWORD": "Il0v3y04",
+					"VSQL_HOST":     "localhost",
+					"VSQL_PORT":     "5433",
 					"VSQL_DATABASE": "VMart",
 				},
 			},
 		},
 	})
 }
+
+func TestAPIKeyImporter(t *testing.T) {
+	plugintest.TestImporter(t, DatabaseCredentials().Importer, map[string]plugintest.ImportCase{
+		"environment": {
+			Environment: map[string]string{
+				"VSQL_USER":     "vertica",
+				"VSQL_PASSWORD": "Il0v3y04",
+				"VSQL_HOST":     "localhost",
+				"VSQL_PORT":     "5433",
+				"VSQL_DATABASE": "VMart",
+			},
+			ExpectedCandidates: []sdk.ImportCandidate{
+				{
+					Fields: map[sdk.FieldName]string{
+						fieldname.Username: "vertica",
+						fieldname.Password: "Il0v3y04",
+						fieldname.Host:     "localhost",
+						fieldname.Port:     "5433",
+						fieldname.Database: "VMart",
+					},
+				},
+			},
+		},
+	})
+}

plugins/vertica/vsql.go

@@ -9,12 +9,11 @@ import (
 
 func VerticaCLI() schema.Executable {
 	return schema.Executable{
-		Name:      "Vertica CLI",
-		Runs:      []string{"vsql"},
-		DocsURL:   sdk.URL("https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ConnectingToVertica/vsql/UsingVsql.htm"), 
+		Name:    "Vertica CLI",
+		Runs:    []string{"vsql"},
+		DocsURL: sdk.URL("https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ConnectingToVertica/vsql/UsingVsql.htm"),
 		NeedsAuth: needsauth.IfAll(
 			needsauth.NotForHelpOrVersion(),
-			needsauth.NotWithoutArgs(),
 		),
 		Uses: []schema.CredentialUsage{
 			{