addressing the review comments

Signed-off-by: Amanda Crawley <[email protected]>

Author: bala-ceg

plugins/binance/api_key.go

@@ -43,8 +43,7 @@ func APIKey() schema.CredentialType {
 			},
 		},
 		DefaultProvisioner: provision.EnvVars(defaultEnvVarMapping),
-		Importer: importer.TryAll(
-			importer.TryEnvVarPair(defaultEnvVarMapping),
+		Importer: importer.TryEnvVarPair(defaultEnvVarMapping,
 		)}
 }
 

plugins/binance/api_key_test.go

@@ -13,12 +13,12 @@ func TestAPIKeyProvisioner(t *testing.T) {
 		"default": {
 			ItemFields: map[sdk.FieldName]string{
 				fieldname.APIKey:    "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
-				fieldname.APISecret: "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
+				fieldname.APISecret: "2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qjThmEycY2J0RgJgNNrWQBqEXAMPLE",
 			},
 			ExpectedOutput: sdk.ProvisionOutput{
 				Environment: map[string]string{
 					"BINANCE_API_KEY":    "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
-					"BINANCE_API_SECRET": "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
+					"BINANCE_API_SECRET": "2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qjThmEycY2J0RgJgNNrWQBqEXAMPLE",
 				},
 			},
 		},
@@ -30,13 +30,13 @@ func TestAPIKeyImporter(t *testing.T) {
 		"environment": {
 			Environment: map[string]string{
 				"BINANCE_API_KEY":    "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
-				"BINANCE_API_SECRET": "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
+				"BINANCE_API_SECRET": "2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qjThmEycY2J0RgJgNNrWQBqEXAMPLE",
 			},
 			ExpectedCandidates: []sdk.ImportCandidate{
 				{
 					Fields: map[sdk.FieldName]string{
 						fieldname.APIKey:    "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
-						fieldname.APISecret: "jThmEycY2J0RgJgNNrWQBq2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qEXAMPLE",
+						fieldname.APISecret: "2raPzKvxCkcwPQFk8AuWUu5QxQSWaItIB1qjThmEycY2J0RgJgNNrWQBqEXAMPLE",
 					},
 				},
 			},

plugins/binance/binance_cli.go

@@ -15,6 +15,16 @@ func BinanceCLI() schema.Executable {
 		NeedsAuth: needsauth.IfAll(
 			needsauth.NotForHelpOrVersion(),
 			needsauth.NotWithoutArgs(),
+			needsauth.NotWhenContainsArgs("t"),
+			needsauth.NotWhenContainsArgs("i"),
+			needsauth.NotWhenContainsArgs("book"),
+			needsauth.NotWhenContainsArgs("at"),
+			needsauth.NotWhenContainsArgs("k"),
+			needsauth.NotWhenContainsArgs("ap"),
+			needsauth.NotWhenContainsArgs("ticker"),
+			needsauth.NotWhenContainsArgs("price"),
+			needsauth.NotWhenContainsArgs("bt"),
+			needsauth.NotWhenContainsArgs("listen"),
 		),
 		Uses: []schema.CredentialUsage{
 			{