Skip to content

Commit f61038e

Browse files
committed
Fix signed commits CI job
The job was previously ran on "pull_request_target". This runs the job on the base branch (i.e. the `main` branch of the 1password/shell-plugins repo). Since we want to know if commits are signed on all the commits to be merged (i.e. also on the fork), I have changed this job to run on the merge commit instead. Relevant documentation: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target Note that the usage example of https://github.com/1Password/check-signed-commits-action also recommends running on the "pull_reqeusts" event.
1 parent 54ec59d commit f61038e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/pr-check-signed-commits.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Check signed commits in PR
2-
on: pull_request_target
2+
on: pull_request
33

44
jobs:
55
build:

0 commit comments

Comments
 (0)