Some small fixtures for next phpstan level

Author: lebeda

README.md

@@ -10,7 +10,7 @@
 ![Static Badge](https://img.shields.io/badge/PHPUnit-tests%3A_171-lightgreen)
 ![Static Badge](https://img.shields.io/badge/PHPUnit-asserts%3A_596-lightgreen)
 ![Static Badge](https://img.shields.io/badge/PHPStan_6-OK-lightgreen)
-![Static Badge](https://img.shields.io/badge/PHPStan_7-16_errors-orange)
+![Static Badge](https://img.shields.io/badge/PHPStan_7|8-16_errors-orange)
 
 **F**i**Q**ue**L**a is a powerful PHP library that brings SQL-inspired querying capabilities to structured data formats
 like **XML**, **CSV**, **JSON**, **YAML** and **NEON**. Designed for simplicity and modularity, it allows you to filter,
@@ -296,7 +296,7 @@ to load all data into memory. It may cause memory issues for large datasets. But
 - [ ] **Next file formats**: Add next file formats like [NDJson](https://github.com/ndjson/ndjson-spec) and [MessagePack](https://msgpack.org/)
 - [ ] **Documentation**: Create detailed guides and examples for advanced use cases.
 - [ ] **Add explain method**: Add method `explain()` for explaining query execution from actual query debugger and provide more complex information about query.
-- [ ] **PHPStan 7**: Fix all PHPStan 7 errors.
+- [ ] **PHPStan 8**: Fix all PHPStan 8 errors.
 - [ ] **Tests**: Increase test coverage.
 - [ ] **Optimize GROUP BY**: Optimize `GROUP BY` for more memory efficient data processing.
 - [ ] **Hashmap cache**: Add hashmap cache (Redis, Memcache) for more memory efficient data processing.

src/Enum/Type.php

@@ -116,7 +116,7 @@ private static function isNumeric(string $value): bool
         $value = preg_replace('/[ ,]/', '', $value);
 
         // Replace comma with dot for unified decimal separator
-        $value = str_replace(',', '.', $value);
+        $value = str_replace(',', '.', $value ?? '');
 
         return is_numeric($value);
     }

src/Functions/String/Base64Decode.php

@@ -20,9 +20,4 @@ public function __invoke(array $item, array $resultItem): mixed
             )
         );
     }
-
-    public function getName(): string
-    {
-        return 'FROM_BASE64';
-    }
 }

src/Functions/String/Base64Encode.php

@@ -20,9 +20,4 @@ public function __invoke(array $item, array $resultItem): mixed
             )
         );
     }
-
-    public function getName(): string
-    {
-        return 'TO_BASE64';
-    }
 }

src/Query/Debugger.php

@@ -220,9 +220,12 @@ public static function echoSection(string $text, ?string $color = 'cyan'): void
         self::echoLine($colorCallback(self::echoBold(str_repeat('=', strlen($text)))), 0);
     }
 
-    public static function echoLineNameValue(string $name, mixed $value, int $beginCharRepeat = 1): void
-    {
-        self::echoLine(sprintf('%s: %s', self::echoBold($name), self::echoCyan($value)), $beginCharRepeat);
+    public static function echoLineNameValue(
+        string $name,
+        string|bool|float|int|null $value,
+        int $beginCharRepeat = 1
+    ): void {
+        self::echoLine(sprintf('%s: %s', self::echoBold($name), self::echoCyan((string) $value)), $beginCharRepeat);
     }
 
     public static function echoLine(string $text, int $beginCharRepeat = 1): void

src/Query/Provider.php

@@ -29,7 +29,7 @@ public static function fromFile(string $path, ?Enum\Format $format = null): Inte
     public static function fromFileQuery(string $fileQuery): Interface\Query
     {
         $queryPath = new FileQuery($fileQuery);
-        $stream = self::fromFile($queryPath->file, $queryPath->extension);
+        $stream = self::fromFile($queryPath->file ?? '', $queryPath->extension);
         if ($queryPath->query === null) {
             return $stream;
         }

src/Sql/Sql.php

@@ -44,7 +44,7 @@ public function toQuery(): Interface\Query
             }
 
             $fileQuery = new Query\FileQuery($this->nextToken());
-            $stream = Stream\Provider::fromFile($fileQuery->file, $fileQuery->extension);
+            $stream = Stream\Provider::fromFile($fileQuery->file ?? '', $fileQuery->extension);
             break;
         }
 
@@ -175,7 +175,7 @@ private function isFunction(string $token): bool
 
     private function getFunction(string $token): string
     {
-        return preg_replace('/(\b(?!_)[A-Z0-9_]{2,}(?<!_))\(.*?\)/i', '$1', $token);
+        return preg_replace('/(\b(?!_)[A-Z0-9_]{2,}(?<!_))\(.*?\)/i', '$1', $token) ?? '';
     }
 
     /**

src/Stream/XmlProvider.php

@@ -139,7 +139,7 @@ private function itemToArray(\SimpleXMLElement $element): string|array
         // If the element has no children and attributes, return a simple value
         $value = trim((string) $element);
         if ($value !== '' && empty($result)) {
-            return Enum\Type::matchByString($value);
+            return Enum\Type::castValue($value, Enum\Type::STRING);
         }
 
         // If the element has children or attributes but also a text value, add it as 'value'

src/Traits/Conditions.php

@@ -114,7 +114,7 @@ public function endGroup(): Query
             throw new Exception\UnexpectedValueException('No group to end');
         }
 
-        $this->currentGroup = $this->currentGroup->getParent();
+        $this->currentGroup = $this->currentGroup->getParent() ?? $this->whereConditions;
         return $this;
     }
 

src/Traits/Helpers/StringOperations.php

@@ -12,10 +12,10 @@ public function camelCaseToUpperSnakeCase(string $input): string
         }
 
         // Add underscores before uppercase letters, unless at the start or after an underscore
-        $snake = preg_replace('/(?<!^|_|[A-Z])([A-Z])/', '_$1', $input);
+        $snake = preg_replace('/(?<!^|_|[A-Z])([A-Z])/', '_$1', $input) ?? '';
 
         // Consolidate multiple underscores into one
-        $snake = preg_replace('/_+/', '_', $snake);
+        $snake = preg_replace('/_+/', '_', $snake) ?? '';
 
         // Convert to uppercase and return the result
         return strtoupper($snake);
@@ -37,7 +37,7 @@ public function extractPlainText(string $input): string
         $cleaned = preg_replace([
             '/```[\s\S]*?```/m', // multi-line code blocks: ```code```
             '/`{1,2}(.*?)`{1,2}/', // single-line code: `inline code`
-        ], '', $input);
+        ], '', $input) ?? '';
 
         // remove all HTML tags
         $cleaned = strip_tags($cleaned);
@@ -54,13 +54,13 @@ public function extractPlainText(string $input): string
             '/^\d+\.\s+(.*)$/m',     // Ordered list: 1. item
             '/\|.*?\|/m',            // Table rows: | col1 | col2 |
             '/-{3,}/',               // Horizontal rules: ---
-        ], '$1', $cleaned);
+        ], '$1', $cleaned) ?? '';
 
         // allowed characters: letters, numbers, spaces, common punctuation
-        $cleaned = preg_replace('/[^\p{L}\p{N}\s.,!?;:\'\"-]/u', '', $cleaned);
+        $cleaned = preg_replace('/[^\p{L}\p{N}\s.,!?;:\'\"-]/u', '', $cleaned) ?? '';
 
         // normalize multiple spaces to one
-        $cleaned = preg_replace('/\s+/', ' ', $cleaned);
+        $cleaned = preg_replace('/\s+/', ' ', $cleaned) ?? '';
         return strtolower(trim($cleaned));
     }
 }