refactor: remove unused code and imports for Go Report Card A+

- Removed unused helper functions from cmd/promptext/main.go
- Removed unused helper functions from pkg/promptext/
- Cleaned up unused imports across the codebase
- Fixed staticcheck U1000 (unused) and SA4006 (unused value) warnings

All tests passing, staticcheck clean, ready for v0.7.1 release.

Author: 1broseidon

cmd/promptext/main.go

@@ -8,7 +8,6 @@ import (
 	"path/filepath"
 	"strings"
 
-	"github.com/1broseidon/promptext/internal/format"
 	"github.com/1broseidon/promptext/internal/initializer"
 	"github.com/1broseidon/promptext/internal/processor"
 	"github.com/1broseidon/promptext/internal/update"
@@ -398,127 +397,6 @@ func formatTokenCount(tokens int) string {
 	return result.String()
 }
 
-// Helper functions to convert between library and internal types
-func parseExtensions(extension string) []string {
-	if extension == "" {
-		return nil
-	}
-	return strings.Split(extension, ",")
-}
-
-func parseExcludes(exclude string) []string {
-	if exclude == "" {
-		return nil
-	}
-	return strings.Split(exclude, ",")
-}
-
-func toInternalProjectOutput(output *promptext.ProjectOutput) *format.ProjectOutput {
-	if output == nil {
-		return nil
-	}
-
-	internal := &format.ProjectOutput{}
-
-	// Convert DirectoryTree
-	if output.DirectoryTree != nil {
-		internal.DirectoryTree = toInternalDirectoryNode(output.DirectoryTree)
-	}
-
-	// Convert GitInfo
-	if output.GitInfo != nil {
-		internal.GitInfo = &format.GitInfo{
-			Branch:        output.GitInfo.Branch,
-			CommitHash:    output.GitInfo.CommitHash,
-			CommitMessage: output.GitInfo.CommitMessage,
-		}
-	}
-
-	// Convert Metadata
-	if output.Metadata != nil {
-		internal.Metadata = &format.Metadata{
-			Language:     output.Metadata.Language,
-			Version:      output.Metadata.Version,
-			Dependencies: output.Metadata.Dependencies,
-		}
-	}
-
-	// Convert Files
-	internal.Files = make([]format.FileInfo, len(output.Files))
-	for i, file := range output.Files {
-		internal.Files[i] = format.FileInfo{
-			Path:    file.Path,
-			Content: file.Content,
-			Tokens:  file.Tokens,
-		}
-		if file.Truncation != nil {
-			internal.Files[i].Truncation = &format.TruncationInfo{
-				Mode:           file.Truncation.Mode,
-				OriginalTokens: file.Truncation.OriginalTokens,
-			}
-		}
-	}
-
-	// Convert FileStats
-	if output.FileStats != nil {
-		internal.FileStats = &format.FileStatistics{
-			TotalFiles:   output.FileStats.TotalFiles,
-			TotalLines:   output.FileStats.TotalLines,
-			PackageCount: output.FileStats.PackageCount,
-		}
-	}
-
-	// Convert Budget
-	if output.Budget != nil {
-		internal.Budget = &format.BudgetInfo{
-			MaxTokens:       output.Budget.MaxTokens,
-			EstimatedTokens: output.Budget.EstimatedTokens,
-			FileTruncations: output.Budget.FileTruncations,
-		}
-	}
-
-	// Convert FilterConfig
-	if output.FilterConfig != nil {
-		internal.FilterConfig = &format.FilterConfig{
-			Includes: output.FilterConfig.Includes,
-			Excludes: output.FilterConfig.Excludes,
-		}
-	}
-
-	return internal
-}
-
-func toInternalDirectoryNode(node *promptext.DirectoryNode) *format.DirectoryNode {
-	if node == nil {
-		return nil
-	}
-
-	internal := &format.DirectoryNode{
-		Name: node.Name,
-		Type: node.Type,
-	}
-
-	if len(node.Children) > 0 {
-		internal.Children = make([]*format.DirectoryNode, len(node.Children))
-		for i, child := range node.Children {
-			internal.Children[i] = toInternalDirectoryNode(child)
-		}
-	}
-
-	return internal
-}
-
-func toInternalExcludedList(list []promptext.ExcludedFileInfo) []processor.ExcludedFileInfo {
-	result := make([]processor.ExcludedFileInfo, len(list))
-	for i, item := range list {
-		result[i] = processor.ExcludedFileInfo{
-			Path:   item.Path,
-			Tokens: item.Tokens,
-		}
-	}
-	return result
-}
-
 type cliDeps struct {
 	stdout         io.Writer
 	stderr         io.Writer

examples/token-budget/main.go

@@ -114,10 +114,10 @@ func main() {
 	fmt.Println("---")
 
 	limits := map[string]int{
-		"GPT-3.5 (4k context)":    2000, // Leave room for response
-		"GPT-4 (8k context)":      6000,
-		"Claude (100k context)":   80000,
-		"GPT-4-Turbo (128k)":      100000,
+		"GPT-3.5 (4k context)":  2000, // Leave room for response
+		"GPT-4 (8k context)":    6000,
+		"Claude (100k context)": 80000,
+		"GPT-4-Turbo (128k)":    100000,
 	}
 
 	for model, limit := range limits {

internal/initializer/initializer_test.go

@@ -416,7 +416,7 @@ func TestInitializer_SecurityInputValidation(t *testing.T) {
 
 	// Test that non-absolute paths are handled correctly
 	init = NewInitializer(".", false, true)
-	err = init.RunQuick()
+	_ = init.RunQuick()
 	// Should not panic, may succeed or fail depending on CWD
 	// Just verify it doesn't panic
 }

internal/initializer/templates_test.go

@@ -65,7 +65,7 @@ func TestTemplateGenerator_Generate(t *testing.T) {
 			name:         "Empty project types",
 			projectTypes: []ProjectType{},
 			includeTests: false,
-			expectExts:   []string{}, // No extensions added for unknown project
+			expectExts:   []string{},               // No extensions added for unknown project
 			expectExc:    []string{".git", ".svn"}, // Only base excludes
 		},
 	}

internal/update/update_test.go

@@ -10,9 +10,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"net"
 	"net/http"
-	"net/http/httptest"
 	"os"
 	"path/filepath"
 	"runtime"
@@ -92,19 +90,6 @@ func (f roundTripperFunc) RoundTrip(req *http.Request) (*http.Response, error) {
 	return f(req)
 }
 
-func newTestServer(t *testing.T, handler http.Handler) *httptest.Server {
-	t.Helper()
-	ln, err := net.Listen("tcp4", "127.0.0.1:0")
-	if err != nil {
-		t.Fatalf("listen: %v", err)
-	}
-	server := httptest.NewUnstartedServer(handler)
-	server.Listener = ln
-	server.Start()
-	t.Cleanup(server.Close)
-	return server
-}
-
 func TestFindReleaseAssets(t *testing.T) {
 	release := &ReleaseInfo{
 		Assets: []struct {

pkg/promptext/options.go

@@ -20,14 +20,14 @@ type config struct {
 // newDefaultConfig creates a config with sensible defaults.
 func newDefaultConfig() *config {
 	return &config{
-		extensions:      nil,        // nil means all supported extensions
-		excludes:        nil,        // nil means no custom excludes
-		gitignore:       true,       // respect .gitignore by default
-		useDefaultRules: true,       // use built-in filtering rules by default
-		tokenBudget:     0,          // 0 means unlimited
-		format:          FormatPTX,  // PTX is the default format
-		verbose:         false,      // quiet by default
-		debug:           false,      // no debug logging by default
+		extensions:      nil,       // nil means all supported extensions
+		excludes:        nil,       // nil means no custom excludes
+		gitignore:       true,      // respect .gitignore by default
+		useDefaultRules: true,      // use built-in filtering rules by default
+		tokenBudget:     0,         // 0 means unlimited
+		format:          FormatPTX, // PTX is the default format
+		verbose:         false,     // quiet by default
+		debug:           false,     // no debug logging by default
 	}
 }
 

pkg/promptext/promptext.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"strings"
 
 	"github.com/1broseidon/promptext/internal/filter"
 	"github.com/1broseidon/promptext/internal/log"
@@ -250,13 +249,3 @@ func validateDirectory(path string) error {
 
 	return nil
 }
-
-// Helper function to join extensions for internal use
-func joinExtensions(extensions []string) string {
-	return strings.Join(extensions, ",")
-}
-
-// Helper function to join excludes for internal use
-func joinExcludes(excludes []string) string {
-	return strings.Join(excludes, ",")
-}

pkg/promptext/result.go

@@ -2,7 +2,6 @@ package promptext
 
 import (
 	"github.com/1broseidon/promptext/internal/format"
-	"github.com/1broseidon/promptext/internal/info"
 	"github.com/1broseidon/promptext/internal/processor"
 )
 
@@ -252,27 +251,3 @@ func fromInternalDirectoryNode(internal *format.DirectoryNode) *DirectoryNode {
 
 	return node
 }
-
-// fromInternalProjectInfo converts internal info.ProjectInfo to public types (used internally)
-func fromInternalProjectInfo(internal *info.ProjectInfo) (*GitInfo, *Metadata) {
-	var gitInfo *GitInfo
-	var metadata *Metadata
-
-	if internal.GitInfo != nil {
-		gitInfo = &GitInfo{
-			Branch:        internal.GitInfo.Branch,
-			CommitHash:    internal.GitInfo.CommitHash,
-			CommitMessage: internal.GitInfo.CommitMessage,
-		}
-	}
-
-	if internal.Metadata != nil {
-		metadata = &Metadata{
-			Language:     internal.Metadata.Language,
-			Version:      internal.Metadata.Version,
-			Dependencies: internal.Metadata.Dependencies,
-		}
-	}
-
-	return gitInfo, metadata
-}