Commit 0e45af6
Address code review feedback - improve comments and code quality
Fixed several issues identified in automated code review:
1. Fixed comment numbering: Changed "6) Build delta-encoded data" to "7)" as it's the 7th step
2. Improved comment accuracy for SemanticTokenTypes.Type - clarified it's for type names (identifiers of types)
3. Updated comment for SemanticTokenTypes.Class - clarified it's for metadata object names (e.g., Контрагенты, Валюты), not metadata types
4. Improved ambiguous identifier comment in visitColumn - explained single identifiers are intentionally treated as variables because distinguishing requires symbol resolution not performed in visitor
5. Clarified newline handling comment in test - explained that merged multiline token length is sum of lines without newlines
6. Better explained emptyRef variable name - matches grammar field 'emptyFer' (typo in grammar for 'emptyRef')
Note: Did NOT remove SemanticTokenTypes.Type from legend as it may be used by future extensions
Note: Did NOT extract duplicate SDBL token collection code as contexts differ (collection vs processing)
Note: Did NOT change multi-line range handling as SDBL contexts are always single-line
Note: Did NOT change middle identifier handling as SDBL doesn't support 3-part column references
All changes improve code documentation and clarity without changing functionality.
All 27 tests passing.
Co-authored-by: nixel2007 <[email protected]>1 parent 952e789 commit 0e45af6
File tree
3 files changed
+11
-8
lines changed- src
- main/java/com/github/_1c_syntax/bsl/languageserver
- providers
- semantictokens
- test/java/com/github/_1c_syntax/bsl/languageserver/providers
3 files changed
+11
-8
lines changedLines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
| 244 | + | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| |||
1131 | 1131 | | |
1132 | 1132 | | |
1133 | 1133 | | |
1134 | | - | |
1135 | | - | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
1136 | 1138 | | |
1137 | 1139 | | |
1138 | 1140 | | |
| |||
1175 | 1177 | | |
1176 | 1178 | | |
1177 | 1179 | | |
1178 | | - | |
| 1180 | + | |
1179 | 1181 | | |
1180 | 1182 | | |
1181 | 1183 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
| 440 | + | |
| 441 | + | |
441 | 442 | | |
442 | 443 | | |
443 | | - | |
| 444 | + | |
444 | 445 | | |
445 | 446 | | |
446 | 447 | | |
| |||
0 commit comments