Merge pull request #3738 from 1c-syntax/copilot/fix-null-pointer-exception

Fix NullPointerException in DeletingCollectionItemDiagnostic for incomplete forEach statements

Author: nixel2007

src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DeletingCollectionItemDiagnostic.java

@@ -67,7 +67,12 @@ private static boolean namesEqual(CallStatementContext callStatement, String col
   @Override
   public ParseTree visitForEachStatement(BSLParser.ForEachStatementContext ctx) {
 
-    String collectionExpression = ctx.expression().getText();
+    var expression = ctx.expression();
+    if (expression == null) {
+      return super.visitForEachStatement(ctx);
+    }
+
+    String collectionExpression = expression.getText();
     Trees.findAllRuleNodes(ctx.codeBlock(), BSLParser.RULE_methodCall)
       .stream()
       .filter(MethodCallContext.class::isInstance)

src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DeletingCollectionItemDiagnosticTest.java

@@ -21,12 +21,14 @@
  */
 package com.github._1c_syntax.bsl.languageserver.diagnostics;
 
+import com.github._1c_syntax.bsl.languageserver.util.TestUtils;
 import org.eclipse.lsp4j.Diagnostic;
 import org.junit.jupiter.api.Test;
 
 import java.util.List;
 
 import static com.github._1c_syntax.bsl.languageserver.util.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
 
 
 class DeletingCollectionItemDiagnosticTest extends AbstractDiagnosticTest<DeletingCollectionItemDiagnostic> {
@@ -50,4 +52,19 @@ void test() {
       .hasRange(55, 4, 55, 39);
   }
 
+  @Test
+  void testIncompleteForEachStatement() {
+    // Test that incomplete forEach statement doesn't cause NullPointerException
+    String module = """
+      Процедура Тест()
+        Для Каждого
+      КонецПроцедуры
+      """;
+
+    var documentContext = TestUtils.getDocumentContext(module);
+
+    assertThatCode(() -> getDiagnostics(documentContext))
+      .doesNotThrowAnyException();
+  }
+
 }