Skip to content

Commit dd1767d

Browse files
Copilotnixel2007
andcommitted
Add given/when/then comments to delta tokens tests
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
1 parent bcfca7a commit dd1767d

File tree

1 file changed

+19
-21
lines changed

1 file changed

+19
-21
lines changed

src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/SemanticTokensProviderTest.java

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,17 +1103,22 @@ void sdblQuery_tableWithObjectTableName() {
11031103

11041104
@Test
11051105
void fullTokensReturnsResultId() {
1106+
// given
11061107
String bsl = """
11071108
Перем А;
11081109
""";
11091110

1111+
// when
11101112
SemanticTokens tokens = getTokens(bsl);
1113+
1114+
// then
11111115
assertThat(tokens.getResultId()).isNotNull();
11121116
assertThat(tokens.getResultId()).isNotEmpty();
11131117
}
11141118

11151119
@Test
11161120
void deltaWithSameDocument_returnsEmptyEdits() {
1121+
// given
11171122
String bsl = """
11181123
Перем А;
11191124
""";
@@ -1122,18 +1127,17 @@ void deltaWithSameDocument_returnsEmptyEdits() {
11221127
referenceIndexFiller.fill(documentContext);
11231128
TextDocumentIdentifier textDocumentIdentifier = TestUtils.getTextDocumentIdentifier(documentContext.getUri());
11241129

1125-
// Get initial tokens
11261130
SemanticTokens initialTokens = provider.getSemanticTokensFull(
11271131
documentContext,
11281132
new SemanticTokensParams(textDocumentIdentifier)
11291133
);
11301134
assertThat(initialTokens.getResultId()).isNotNull();
11311135

1132-
// Request delta with same document (unchanged)
1136+
// when
11331137
var deltaParams = new SemanticTokensDeltaParams(textDocumentIdentifier, initialTokens.getResultId());
11341138
var result = provider.getSemanticTokensFullDelta(documentContext, deltaParams);
11351139

1136-
// Should return delta with empty edits since document is unchanged
1140+
// then
11371141
assertThat(result.isRight()).isTrue();
11381142
var delta = result.getRight();
11391143
assertThat(delta.getResultId()).isNotNull();
@@ -1143,6 +1147,7 @@ void deltaWithSameDocument_returnsEmptyEdits() {
11431147

11441148
@Test
11451149
void deltaWithUnknownPreviousResultId_returnsFullTokens() {
1150+
// given
11461151
String bsl = """
11471152
Перем А;
11481153
""";
@@ -1151,11 +1156,11 @@ void deltaWithUnknownPreviousResultId_returnsFullTokens() {
11511156
referenceIndexFiller.fill(documentContext);
11521157
TextDocumentIdentifier textDocumentIdentifier = TestUtils.getTextDocumentIdentifier(documentContext.getUri());
11531158

1154-
// Request delta with unknown previous result ID
1159+
// when
11551160
var deltaParams = new SemanticTokensDeltaParams(textDocumentIdentifier, "unknown-result-id");
11561161
var result = provider.getSemanticTokensFullDelta(documentContext, deltaParams);
11571162

1158-
// Should return full tokens (left side of Either)
1163+
// then
11591164
assertThat(result.isLeft()).isTrue();
11601165
var fullTokens = result.getLeft();
11611166
assertThat(fullTokens.getResultId()).isNotNull();
@@ -1164,6 +1169,7 @@ void deltaWithUnknownPreviousResultId_returnsFullTokens() {
11641169

11651170
@Test
11661171
void deltaWithChangedDocument_returnsEdits() {
1172+
// given
11671173
String bsl1 = """
11681174
Перем А;
11691175
""";
@@ -1173,30 +1179,29 @@ void deltaWithChangedDocument_returnsEdits() {
11731179
Перем Б;
11741180
""";
11751181

1176-
// Get tokens for first version
11771182
DocumentContext context1 = TestUtils.getDocumentContext(bsl1);
11781183
referenceIndexFiller.fill(context1);
11791184
TextDocumentIdentifier textDocId1 = TestUtils.getTextDocumentIdentifier(context1.getUri());
11801185
SemanticTokens tokens1 = provider.getSemanticTokensFull(context1, new SemanticTokensParams(textDocId1));
11811186

1182-
// Create a second document context with a DIFFERENT URI
11831187
URI differentUri = URI.create("file:///fake/different-document.bsl");
11841188
DocumentContext context2 = TestUtils.getDocumentContext(differentUri, bsl2);
11851189
referenceIndexFiller.fill(context2);
11861190
TextDocumentIdentifier textDocId2 = TestUtils.getTextDocumentIdentifier(context2.getUri());
11871191

1188-
// Request delta using the first result ID but on a different document
1192+
// when
11891193
var deltaParams = new SemanticTokensDeltaParams(textDocId2, tokens1.getResultId());
11901194
var result = provider.getSemanticTokensFullDelta(context2, deltaParams);
11911195

1192-
// Since URI is different, should return full tokens (left side of Either)
1196+
// then
11931197
assertThat(result.isLeft()).isTrue();
11941198
var fullTokens = result.getLeft();
11951199
assertThat(fullTokens.getResultId()).isNotNull();
11961200
}
11971201

11981202
@Test
11991203
void deltaWithModifiedSameDocument_returnsEdits() {
1204+
// given
12001205
String bsl1 = """
12011206
Перем А;
12021207
""";
@@ -1206,36 +1211,31 @@ void deltaWithModifiedSameDocument_returnsEdits() {
12061211
Перем Б;
12071212
""";
12081213

1209-
// Get tokens for first version
12101214
DocumentContext context1 = TestUtils.getDocumentContext(bsl1);
12111215
referenceIndexFiller.fill(context1);
12121216
TextDocumentIdentifier textDocId1 = TestUtils.getTextDocumentIdentifier(context1.getUri());
12131217
SemanticTokens tokens1 = provider.getSemanticTokensFull(context1, new SemanticTokensParams(textDocId1));
1214-
int originalSize = tokens1.getData().size();
12151218

1216-
// Simulate document being modified (same URI, different content)
1217-
// Use the same URI to simulate updating the same document
12181219
DocumentContext context2 = TestUtils.getDocumentContext(context1.getUri(), bsl2);
12191220
referenceIndexFiller.fill(context2);
12201221

1221-
// Request delta using the first result ID
1222+
// when
12221223
var deltaParams = new SemanticTokensDeltaParams(textDocId1, tokens1.getResultId());
12231224
var result = provider.getSemanticTokensFullDelta(context2, deltaParams);
12241225

1225-
// Should return delta with edits since document was modified (same URI)
1226+
// then
12261227
assertThat(result.isRight()).isTrue();
12271228
var delta = result.getRight();
12281229
assertThat(delta.getResultId()).isNotNull();
1229-
// There should be at least one edit since we added a new line
12301230
assertThat(delta.getEdits()).isNotEmpty();
1231-
// Verify that the edit adds new token data (for "Перем Б;")
12321231
var edit = delta.getEdits().get(0);
12331232
assertThat(edit.getDeleteCount() + (edit.getData() != null ? edit.getData().size() : 0))
12341233
.isGreaterThan(0);
12351234
}
12361235

12371236
@Test
12381237
void clearCache_removesCachedTokenData() {
1238+
// given
12391239
String bsl = """
12401240
Перем А;
12411241
""";
@@ -1244,20 +1244,18 @@ void clearCache_removesCachedTokenData() {
12441244
referenceIndexFiller.fill(documentContext);
12451245
TextDocumentIdentifier textDocumentIdentifier = TestUtils.getTextDocumentIdentifier(documentContext.getUri());
12461246

1247-
// Get initial tokens (this caches the result)
12481247
SemanticTokens initialTokens = provider.getSemanticTokensFull(
12491248
documentContext,
12501249
new SemanticTokensParams(textDocumentIdentifier)
12511250
);
12521251

1253-
// Clear cache directly
1252+
// when
12541253
provider.clearCache(documentContext.getUri());
12551254

1256-
// Request delta with the old result ID
12571255
var deltaParams = new SemanticTokensDeltaParams(textDocumentIdentifier, initialTokens.getResultId());
12581256
var result = provider.getSemanticTokensFullDelta(documentContext, deltaParams);
12591257

1260-
// Should return full tokens because cache was cleared
1258+
// then
12611259
assertThat(result.isLeft()).isTrue();
12621260
}
12631261

0 commit comments

Comments
 (0)