Add empty response for textDocument/implementation request#3699
Add empty response for textDocument/implementation request#3699
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
|
/buildJar |
Test Results2 781 files ±0 2 781 suites ±0 48m 41s ⏱️ +10s Results for commit ae8c484. ± Comparison against base commit d80ae40. This pull request removes 8 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
✅ Собраны JAR-файлы для этого PR по команде Артефакт: 4963019086 Файлы внутри:
|
There was a problem hiding this comment.
Pull request overview
This PR adds a stub handler for the textDocument/implementation LSP request to prevent client errors. The implementation intentionally returns an empty list without declaring capabilities or providing actual functionality.
Key Changes:
- Added stub
implementation()method that returns an emptyLocationLinklist - Added test to verify the stub returns the expected empty response
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/github/_1c_syntax/bsl/languageserver/BSLTextDocumentService.java | Adds stub implementation() method that returns empty list wrapped in CompletableFuture |
| src/test/java/com/github/_1c_syntax/bsl/languageserver/BSLTextDocumentServiceTest.java | Adds test verifying the stub method returns non-null empty response |
The implementation is clean and appropriate for its purpose as a stub handler. The code follows Java conventions, properly uses the LSP4J types, and includes adequate test coverage. No issues were identified.
Adds a stub handler for
textDocument/implementationthat returns an empty list. No capability declared, no provider—just prevents clients from getting an error when they send this request.Changes
implementation()to return emptyLocationLinklistOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.