Skip to content

Conversation

@theshadowco
Copy link
Member

@theshadowco theshadowco commented Dec 29, 2025

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

  • Chores
    • Enhanced test reporting in CI/CD pipeline. Test reports are now automatically published as artifacts when build failures occur, providing immediate access to detailed test results across different configurations for faster issue diagnosis and resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Walkthrough

The GitHub Actions workflow for the Gradle build job is enhanced to capture and upload test reports as artifacts when the build fails, enabling easier access to test results from failed CI runs.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/gradle.yml
Added "Publish Test report" step to upload JUnit test reports on build failure using actions/upload-artifact@v5. Minor YAML formatting adjustment with no functional impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through CI/CD dreams,
Where tests now glow in glowing beams,
When failures come, reports take flight,
Artifacts captured, shining bright! ✨
Debugging's easier, all seems right! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding test report saving on build failure in the CI/CD workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch theshadowco-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/gradle.yml (1)

56-61: Use consistent action versions across the workflow.

Line 58 uses actions/upload-artifact@v5, while line 52 uses @v6. Mixing versions within the same workflow can lead to inconsistent behavior and makes maintenance more difficult. Upgrade to v6 for consistency—there are no behavioral breaking changes between v5 and v6 that would affect this step.

    - name: Publish Test report
      if: failure()
-     uses: actions/upload-artifact@v5
+     uses: actions/upload-artifact@v6
      with:
        name: junit_report_${{ matrix.os }}_${{ matrix.java_version }}
        path: build/reports/tests/test
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 116269d and 7834b0c.

📒 Files selected for processing (1)
  • .github/workflows/gradle.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (17, macOS-latest)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: Analyse
  • GitHub Check: build
  • GitHub Check: Analyze the repo with CodeSee
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: build (25, macOS-latest)
  • GitHub Check: build (17, macOS-latest)
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: build

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Test Results

2 781 files  ±0  2 781 suites  ±0   52m 30s ⏱️ + 3m 24s
1 109 tests ±0  1 109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
9 981 runs  ±0  9 981 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7834b0c. ± Comparison against base commit 116269d.

This pull request removes 8 and adds 4 tests. Note that renamed tests count towards both.
#, count=1
, count=0
, count=1
A, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [2] content=
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [6] content=
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [7] content=#
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [8] content=
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [2] content=
, count=0
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [6] content=
A, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [7] content=#
, count=1
com.github._1c_syntax.bsl.languageserver.diagnostics.MetadataObjectNameLengthDiagnosticTest ‑ [8] content=
#, count=1

♻️ This comment has been updated with latest results.

@nixel2007 nixel2007 merged commit bfc5d8a into develop Dec 29, 2025
57 of 60 checks passed
@nixel2007 nixel2007 deleted the theshadowco-patch-1 branch December 29, 2025 08:22
@nixel2007
Copy link
Member

Спасибо!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants