заполнение новых свойств диагностики

Author: theshadowco

src/main/java/com/github/_1c_syntax/bsl/sonar/language/BSLLanguageServerRuleDefinition.java

@@ -54,6 +54,7 @@
 import javax.annotation.CheckForNull;
 import java.util.Arrays;
 import java.util.EnumMap;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -161,11 +162,7 @@ private void setUpNewRule(NewRule newRule) {
       .ifPresent(newRule::setCleanCodeAttribute);
 
     // заполним влияние
-    diagnosticInfo.getTags().forEach(tag -> {
-        var impact = IMPACTS_MAP.get(tag);
-        newRule.addDefaultImpact(impact.getLeft(), impact.getRight());
-      }
-    );
+    computeImpact(diagnosticInfo.getTags()).forEach(newRule::addDefaultImpact);
 
     if (diagnosticInfo.getExtraMinForComplexity() > 0) {
       newRule.setDebtRemediationFunction(
@@ -211,6 +208,18 @@ private Language createDiagnosticLanguage() {
     return Language.valueOf(diagnosticLanguageCode.toUpperCase(Locale.ENGLISH));
   }
 
+  private static Map<SoftwareQuality, Severity> computeImpact(List<DiagnosticTag> tags) {
+    Map<SoftwareQuality, Severity> map = new HashMap<>();
+    tags.forEach((DiagnosticTag tag) -> {
+      var impact = IMPACTS_MAP.get(tag);
+      var value = map.get(impact.getLeft());
+      if (value == null || impact.getRight().compareTo(value) > 0) {
+        map.put(impact.getLeft(), impact.getRight());
+      }
+    });
+    return map;
+  }
+
   @CheckForNull
   private static RuleParamType getRuleParamType(Class<?> type) {