add tests

Author: theshadowco

src/main/java/com/github/_1c_syntax/bsl/sonar/language/BSLLanguageServerRuleDefinition.java

@@ -167,15 +167,13 @@ private void setUpRuleParams(NewRule newRule) {
       .forEach((DiagnosticParameterInfo diagnosticParameter) -> {
         var ruleParamType = getRuleParamType(diagnosticParameter.getType());
         if (ruleParamType == null) {
-          LOGGER.error("Can't cast rule param type {} for rule {}",
-            diagnosticParameter.getType(), newRule.key());
-          return;
+          LOGGER.error("Can't cast rule param type {} for rule {}", diagnosticParameter.getType(), newRule.key());
+        } else {
+          var newParam = newRule.createParam(diagnosticParameter.getName());
+          newParam.setType(ruleParamType);
+          newParam.setDescription(diagnosticParameter.getDescription());
+          newParam.setDefaultValue(diagnosticParameter.getDefaultValue().toString());
         }
-
-        var newParam = newRule.createParam(diagnosticParameter.getName());
-        newParam.setType(ruleParamType);
-        newParam.setDescription(diagnosticParameter.getDescription());
-        newParam.setDefaultValue(diagnosticParameter.getDefaultValue().toString());
       });
   }
 

src/test/java/com/github/_1c_syntax/bsl/sonar/LanguageServerDiagnosticsLoaderSensorTest.java

@@ -57,7 +57,7 @@ void test_execute() {
     var fileName = "src/test.bsl";
     var inputFile = Tools.inputFileBSL(fileName, BASE_DIR);
 
-    var sonarRuntime = SonarRuntimeImpl.forSonarLint(Version.create(7, 9));
+    var sonarRuntime = SonarRuntimeImpl.forSonarLint(Version.create(25, 7));
     var context = SensorContextTester.create(BASE_DIR);
     context.setRuntime(sonarRuntime);
     context.settings().setProperty(
@@ -79,4 +79,33 @@ void test_execute() {
     assertThat(context.isCancelled()).isFalse();
 
   }
+
+  @Test
+  void test_error() {
+
+    var fileName = "src/test6.bsl";
+    var inputFile = Tools.inputFileBSL(fileName, BASE_DIR);
+
+    var sonarRuntime = SonarRuntimeImpl.forSonarLint(Version.create(25, 4));
+    var context = SensorContextTester.create(BASE_DIR);
+    context.setRuntime(sonarRuntime);
+    context.settings().setProperty(
+      "sonar.bsl.languageserver.reportPaths",
+      ".bsl-language-server.json, fake.json, highlight.bsl");
+    context.fileSystem().add(inputFile);
+
+    var activeRules = new ActiveRulesBuilder()
+      .addRule(new NewActiveRule.Builder()
+        .setRuleKey(RuleKey.of(BSLLanguageServerRuleDefinition.REPOSITORY_KEY, "OneStatementPerLine"))
+        .setName("OneStatementPerLine")
+        .build())
+      .build();
+    context.setActiveRules(activeRules);
+
+    var diagnosticsLoaderSensor = new LanguageServerDiagnosticsLoaderSensor(context);
+    diagnosticsLoaderSensor.execute(context);
+
+    assertThat(context.isCancelled()).isFalse();
+
+  }
 }