fix: test line code fix?

Author: 1drturtle

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "avrae-ls"
-version = "0.7.0"
+version = "0.7.1"
 description = "Language server for Avrae draconic aliases"
 authors = [
   { name = "1drturtle" }

src/avrae_ls/__main__.py

@@ -202,11 +202,17 @@ def _print_test_results(results: Iterable[AliasTestResult], workspace_root: Path
             passed += 1
             continue
         if res.error:
-            if res.error_line is not None:
-                alias_name = res.case.alias_path.name
-                print(f"  Error (line {res.error_line} {alias_name}): {res.error}")
+            if res.error_line is not None and res.error_col is not None:
+                label = f"  Execution Error (line {res.error_line} col {res.error_col})"
+            elif res.error_line is not None:
+                label = f"  Execution Error (line {res.error_line})"
             else:
-                print(f"  Error: {res.error}")
+                label = "  Execution Error"
+            print(_colorize_error_line(label))
+            print(f"    {res.error}")
+            if res.stdout:
+                print(f"  Stdout: {res.stdout.strip()}")
+            continue
         if res.details:
             print(f"  {res.details}")
         expected_val, actual_val = _summarize_mismatch(res.case.expected, res.actual)
@@ -262,6 +268,12 @@ def _colorize_diff_line(line: str) -> str:
     return line
 
 
+def _colorize_error_line(line: str) -> str:
+    if not sys.stdout.isatty():
+        return line
+    return f"\x1b[31m{line}\x1b[0m"
+
+
 def _print_labeled_value(label: str, value: str) -> None:
     lines = value.splitlines() or [""]
     if len(lines) == 1:

src/avrae_ls/alias_preview.py

@@ -18,6 +18,7 @@ class RenderedAlias:
     error: Optional[BaseException]
     last_value: Any | None = None
     error_line: int | None = None
+    error_col: int | None = None
 
 
 @dataclass
@@ -81,18 +82,43 @@ def _line_index_for_offset(text: str, offset: int) -> int:
     return text.count("\n", 0, offset)
 
 
-def _error_line_for_match(
+def _error_position_for_match(
     body: str, match: re.Match[str], error: BaseException, line_offset: int
-) -> int | None:
+) -> tuple[int | None, int | None]:
     base_line = _line_index_for_offset(body, match.start(1))
-    lineno = getattr(error, "lineno", None)
-    if isinstance(lineno, int) and lineno > 0 and getattr(error, "text", None) is not None:
-        line_index = base_line + (lineno - 1)
+    base_line_start = body.rfind("\n", 0, match.start(1))
+    base_col = match.start(1) - (base_line_start + 1 if base_line_start != -1 else 0)
+    line_in_code: int | None = None
+    col_in_code: int | None = None
+    node = getattr(error, "node", None)
+    if node is not None:
+        node_line = getattr(node, "lineno", None)
+        if isinstance(node_line, int) and node_line > 0:
+            line_in_code = node_line
+        node_col = getattr(node, "col_offset", None)
+        if isinstance(node_col, int) and node_col >= 0:
+            col_in_code = node_col
+    if line_in_code is None:
+        lineno = getattr(error, "lineno", None)
+        if isinstance(lineno, int) and lineno > 0:
+            line_in_code = lineno
+        offset = getattr(error, "offset", None)
+        if isinstance(offset, int) and offset > 0:
+            col_in_code = offset - 1
+    if line_in_code is not None:
+        line_index = base_line + (line_in_code - 1)
     else:
         code = match.group(1)
         leading_newlines = len(code) - len(code.lstrip("\n"))
         line_index = base_line + leading_newlines
-    return line_index + line_offset + 1
+        col_in_code = 0 if col_in_code is None else col_in_code
+    if col_in_code is None:
+        col_in_code = 0
+    if line_in_code is None or line_in_code == 1:
+        col_index = base_col + col_in_code
+    else:
+        col_index = col_in_code
+    return line_index + line_offset + 1, col_index + 1
 
 
 async def render_alias_command(
@@ -110,6 +136,7 @@ async def render_alias_command(
     last_value = None
     error: BaseException | None = None
     error_line: int | None = None
+    error_col: int | None = None
 
     pos = 0
     matches: list[tuple[str, re.Match[str]]] = []
@@ -134,7 +161,7 @@ async def render_alias_command(
                 stdout_parts.append(result.stdout)
             if result.error:
                 error = result.error
-                error_line = _error_line_for_match(body, match, result.error, line_offset)
+                error_line, error_col = _error_position_for_match(body, match, result.error, line_offset)
                 break
             last_value = result.value
             if result.value is not None:
@@ -156,6 +183,7 @@ async def render_alias_command(
         error=error,
         last_value=last_value,
         error_line=error_line,
+        error_col=error_col,
     )
 
 

src/avrae_ls/alias_tests.py

@@ -43,6 +43,7 @@ class AliasTestResult:
     error: str | None = None
     details: str | None = None
     error_line: int | None = None
+    error_col: int | None = None
 
 
 def discover_test_files(
@@ -161,6 +162,7 @@ async def run_alias_test(case: AliasTestCase, builder: ContextBuilder, executor:
             stdout=rendered.stdout,
             error=str(rendered.error),
             error_line=rendered.error_line,
+            error_col=rendered.error_col,
         )
 
     preview = simulate_command(rendered.command)
@@ -173,7 +175,15 @@ async def run_alias_test(case: AliasTestCase, builder: ContextBuilder, executor:
             error=preview.validation_error,
         )
 
-    actual = preview.preview if preview.preview is not None else rendered.last_value
+    if preview.preview is not None:
+        actual = preview.preview
+    else:
+        if rendered.command.strip() == "" and rendered.last_value is None:
+            actual = None
+        elif rendered.last_value is not None and rendered.command.strip() == str(rendered.last_value):
+            actual = rendered.last_value
+        else:
+            actual = rendered.command
     embed_dict = preview.embed.to_dict() if preview.embed else None
 
     if embed_dict is not None and isinstance(case.expected, dict):

tests/test_alias_tests.py

@@ -1,6 +1,7 @@
 import pytest
 
 from avrae_ls.alias_tests import AliasTestError, parse_alias_tests, run_alias_tests
+from avrae_ls.__main__ import _run_alias_tests
 from avrae_ls.config import AvraeLSConfig
 from avrae_ls.context import ContextBuilder
 from avrae_ls.runtime import MockExecutor
@@ -80,6 +81,60 @@ async def test_alias_tests_include_error_line(tmp_path):
     assert result.error_line == 3
 
 
+@pytest.mark.asyncio
+async def test_alias_tests_include_error_line_with_inline_drac2_tag(tmp_path):
+    alias_path = tmp_path / "embed-error.alias"
+    alias_path.write_text(
+        '!alias embed-error embed <drac2>\n# testing 123\na = 3\n# testing 456\nload_json("")\n</drac2>\n'
+    )
+    test_path = tmp_path / "test-embed-error.alias-test"
+    test_path.write_text("!embed-error\n---\n\n")
+
+    config = AvraeLSConfig.default(tmp_path)
+    builder = ContextBuilder(config)
+    executor = MockExecutor(config.service)
+
+    case = parse_alias_tests(test_path)[0]
+    result = (await run_alias_tests([case], builder, executor))[0]
+
+    assert not result.passed
+    assert result.error is not None
+    assert result.error_line == 5
+
+
+def test_run_tests_output_uses_rendered_command(tmp_path, capsys):
+    (tmp_path / ".avraels.json").write_text('{"enableGvarFetch": false}')
+    alias_path = tmp_path / "speak.alias"
+    alias_path.write_text("!alias speak say hello {{1 + 2}}")
+    test_path = tmp_path / "test-speak.alias-test"
+    test_path.write_text("!speak\n---\nsay hello 4\n")
+
+    exit_code = _run_alias_tests(tmp_path)
+    captured = capsys.readouterr()
+
+    assert exit_code == 1
+    assert "Expected: say hello 4" in captured.out
+    assert "Actual: say hello 3" in captured.out
+
+
+def test_run_tests_output_skips_diff_on_execution_error(tmp_path, capsys):
+    (tmp_path / ".avraels.json").write_text('{"enableGvarFetch": false}')
+    alias_path = tmp_path / "boom.alias"
+    alias_path.write_text("!alias boom echo\n<drac2>\nload_json(\"\")\n</drac2>\n")
+    test_path = tmp_path / "test-boom.alias-test"
+    test_path.write_text("!boom\n---\nshould not compare\n")
+
+    exit_code = _run_alias_tests(tmp_path)
+    captured = capsys.readouterr()
+
+    assert exit_code == 1
+    assert "Execution Error" in captured.out
+    assert "- Execution Error" not in captured.out
+    assert "Expected:" not in captured.out
+    assert "Actual:" not in captured.out
+    assert "Diff:" not in captured.out
+
+
 @pytest.mark.asyncio
 async def test_runs_embed_alias_test(tmp_path):
     alias_path = tmp_path / "embedtest.alias"

uv.lock

@@ -2,7 +2,7 @@
   "name": "avrae-ls-client",
   "displayName": "Avrae Draconic Alias Language Server",
   "description": "VS Code client for avrae-ls (draconic alias diagnostics and mock execution).",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "engines": {
     "vscode": "^1.84.0"
   },