Fix hang when max_execution_time is zero

Author: scottlucas

src/RedisSessionHandler.php

@@ -199,8 +199,13 @@ public function gc($maxlifetime)
     private function acquireLockOn($session_id)
     {
         $wait = self::MIN_WAIT_TIME;
+        if ($this->lock_ttl) {
+            $options = ['nx', 'ex' => $this->lock_ttl];
+        } else {
+            $options = ['nx'];
+        }
 
-        while (false === $this->redis->set("{$session_id}_lock", '', ['nx', 'ex' => $this->lock_ttl])) {
+        while (false === $this->redis->set("{$session_id}_lock", '', $options)) {
             usleep($wait);
 
             if (self::MAX_WAIT_TIME > $wait) {

tests/e2e/BasicTest.php

@@ -137,6 +137,20 @@ public function testFlushedDatabase()
         $this->assertSame(1, $this->redis->dbSize());
     }
 
+    /**
+     * This test checks that the server behaves correctly when a script is run that has no time limit
+     */
+    public function testUnlimitedExecutionTime()
+    {
+        $response = $this->http->send(
+            new Request('GET', '/visit-counter.php?with_no_time_limit')
+        );
+
+        $this->assertSame('1', (string) $response->getBody());
+        $this->assertCreatedNewSession($response);
+        $this->assertSame(1, $this->redis->dbSize());
+    }
+
     /**
      * Asserts whether a received request triggered the creation of a new session.
      * It does so by searching for and inspecting the 'Set-Cookie' header.

tests/webroot/visit-counter.php

@@ -6,6 +6,10 @@
 
 require_once __DIR__.'/../../vendor/autoload.php';
 
+if (isset($_GET['with_no_time_limit'])) {
+    set_time_limit(0);
+}
+
 session_set_save_handler(new \UMA\RedisSessionHandler(), true);
 
 session_start();