working color picker

Author: Roberto De Ioris

Source/UnrealEnginePython/Private/Slate/UEPySlate.cpp

@@ -12,6 +12,8 @@
 #include "Runtime/Slate/Public/Widgets/Views/STableRow.h"
 #include "Editor/ContentBrowser/Public/ContentBrowserModule.h"
 
+#include "Runtime/AppFramework/Public/Widgets/Colors/SColorPicker.h"
+
 
 #include "UEPySlate.h"
 
@@ -110,6 +112,17 @@ void UPythonSlateDelegate::OnFloatChanged(float value) {
 	Py_DECREF(ret);
 }
 
+void UPythonSlateDelegate::OnLinearColorChanged(FLinearColor color) {
+	FScopePythonGIL gil;
+
+	PyObject *ret = PyObject_CallFunction(py_callable, (char *)"O", py_ue_new_flinearcolor(color));
+	if (!ret) {
+		unreal_engine_py_log_error();
+		return;
+	}
+	Py_DECREF(ret);
+}
+
 void UPythonSlateDelegate::OnFloatCommitted(float value, ETextCommit::Type commit_type) {
 	FScopePythonGIL gil;
 
@@ -811,3 +824,39 @@ PyObject *py_unreal_engine_unregister_nomad_tab_spawner(PyObject * self, PyObjec
 	Py_INCREF(Py_None);
 	return Py_None;
 }
+
+
+PyObject *py_unreal_engine_open_color_picker(PyObject *self, PyObject *args, PyObject *kwargs) {
+
+	PyObject *py_callable_on_color_committed = nullptr;
+
+	char *kwlist[] = {
+		(char *)"on_color_committed",
+		nullptr };
+	if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O:open_color_picker", kwlist,
+		&py_callable_on_color_committed)) {
+		return nullptr;
+	}
+
+	if (!PyCallable_Check(py_callable_on_color_committed)) {
+		return PyErr_Format(PyExc_Exception, "on_color_committed must be a callable");
+	}
+
+	UPythonSlateDelegate *py_delegate = NewObject<UPythonSlateDelegate>();
+	py_delegate->SetPyCallable(py_callable_on_color_committed);
+	// TODO: this memory should be freed...
+	py_delegate->AddToRoot();
+
+	FColorPickerArgs color_args;
+	color_args.OnColorCommitted.BindUObject(py_delegate, &UPythonSlateDelegate::OnLinearColorChanged);
+
+	if (OpenColorPicker(color_args)) {
+		Py_RETURN_TRUE;
+	}
+	Py_RETURN_FALSE;
+}
+
+PyObject *py_unreal_engine_destroy_color_picker(PyObject *self, PyObject * args) {
+	DestroyColorPicker();
+	Py_RETURN_NONE;
+}

Source/UnrealEnginePython/Private/Slate/UEPySlate.h

@@ -85,6 +85,9 @@ PyObject *py_unreal_engine_add_tool_bar_extension(PyObject *, PyObject *);
 PyObject *py_unreal_engine_register_nomad_tab_spawner(PyObject *, PyObject *);
 PyObject *py_unreal_engine_unregister_nomad_tab_spawner(PyObject *, PyObject *);
 
+PyObject *py_unreal_engine_open_color_picker(PyObject *, PyObject *, PyObject *);
+PyObject *py_unreal_engine_destroy_color_picker(PyObject *, PyObject *);
+
 void ue_py_register_swidget(SWidget *, ue_PySWidget *);
 void ue_py_unregister_swidget(SWidget *);
 
@@ -111,6 +114,8 @@ template<typename T> ue_PySWidget *py_ue_new_swidget(TSharedRef<SWidget> s_widge
 
 #define ue_py_snew_with_args(T, field, args) ue_py_snew_base(T, field, RequiredArgs::MakeRequiredArgs(args), arguments)
 
+
+
 ue_PySWidget *ue_py_get_swidget(TSharedRef<SWidget> s_widget);
 
 #define ue_py_slate_base_up(_base, _func, _param, _attribute) \
@@ -382,6 +387,8 @@ class UPythonSlateDelegate : public UPythonDelegate
 	void OnFloatChanged(float value);
 	void OnFloatCommitted(float value, ETextCommit::Type commit_type);
 
+	void OnLinearColorChanged(FLinearColor color);
+
 	void OnStringChanged(const FString &text);
 
 	TSharedRef<SDockTab> SpawnPythonTab(const FSpawnTabArgs& args);

Source/UnrealEnginePython/Private/UEPyEngine.cpp

@@ -3,7 +3,7 @@
 #include "Kismet/KismetSystemLibrary.h"
 #include "Kismet/KismetMathLibrary.h"
 
-#include "Runtime/AppFramework/Public/Widgets/Colors/SColorPicker.h"
+
 
 PyObject *py_unreal_engine_log(PyObject * self, PyObject * args) {
 	PyObject *py_message;
@@ -701,15 +701,3 @@ PyObject *py_unreal_engine_editor_get_pie_viewport_size(PyObject *self, PyObject
 #endif
 
 
-PyObject *py_unreal_engine_open_color_picker(PyObject *self, PyObject * args) {
-	FColorPickerArgs color_args;
-	if (OpenColorPicker(color_args)) {
-		Py_RETURN_TRUE;
-	}
-	Py_RETURN_FALSE;
-}
-
-PyObject *py_unreal_engine_destroy_color_picker(PyObject *self, PyObject * args) {
-	DestroyColorPicker();
-	Py_RETURN_NONE;
-}

Source/UnrealEnginePython/Private/UEPyEngine.h

@@ -45,8 +45,6 @@ PyObject *py_unreal_engine_convert_relative_path_to_full(PyObject *, PyObject *)
 PyObject *py_unreal_engine_get_viewport_screenshot(PyObject *, PyObject *);
 PyObject *py_unreal_engine_get_viewport_size(PyObject *, PyObject *);
 
-PyObject *py_unreal_engine_open_color_picker(PyObject *, PyObject *);
-PyObject *py_unreal_engine_destroy_color_picker(PyObject *, PyObject *);
 
 #if WITH_EDITOR
 PyObject *py_unreal_engine_editor_get_active_viewport_screenshot(PyObject *, PyObject *);

Source/UnrealEnginePython/Private/UEPyModule.cpp

@@ -278,8 +278,8 @@ static PyMethodDef unreal_engine_methods[] = {
 	{ "get_viewport_size", py_unreal_engine_get_viewport_size, METH_VARARGS, "" },
 
 	{ "get_game_viewport_client", py_unreal_engine_get_game_viewport_client, METH_VARARGS, "" },
-
-	{ "open_color_picker", py_unreal_engine_open_color_picker, METH_VARARGS, "" },
+#pragma warning(suppress: 4191)
+	{ "open_color_picker", (PyCFunction)py_unreal_engine_open_color_picker, METH_VARARGS| METH_KEYWORDS, "" },
 	{ "destroy_color_picker", py_unreal_engine_destroy_color_picker, METH_VARARGS, "" },
 #if WITH_EDITOR
 	{ "editor_play_in_viewport", py_unreal_engine_editor_play_in_viewport, METH_VARARGS, "" },