added delegate support to IHttpRequest

Author: Roberto De Ioris

Source/UnrealEnginePython/Private/UEPyIHttpRequest.cpp

@@ -129,7 +129,45 @@ static PyObject *py_ue_ihttp_request_get_response(ue_PyIHttpRequest *self, PyObj
 	return py_ue_new_ihttp_response(response.Get());
 }
 
+void UPythonHttpDelegate::OnRequestComplete(FHttpRequestPtr request, FHttpResponsePtr response, bool successful) {
+	FScopePythonGIL gil;
+
+	if (!request.IsValid() || !response.IsValid()) {
+		UE_LOG(LogPython, Error, TEXT("Unable to retrieve HTTP infos"));
+		return;
+	}
+
+	PyObject *ret = PyObject_CallFunction(py_callable, (char *)"OOO", py_http_request, py_ue_new_ihttp_response(response.Get()), successful ? Py_True : Py_False);
+	if (!ret) {
+		unreal_engine_py_log_error();
+		return;
+	}
+	Py_DECREF(ret);
+}
+
+static PyObject *py_ue_ihttp_request_bind_on_process_request_complete(ue_PyIHttpRequest *self, PyObject * args) {
+
+	PyObject *py_callable;
+	if (!PyArg_ParseTuple(args, "O:bind_on_process_request_complete", &py_callable)) {
+		return NULL;
+	}
+
+	if (!PyCallable_Check(py_callable)) {
+		return PyErr_Format(PyExc_Exception, "argument is not a callable");
+	}
+
+	UPythonHttpDelegate *py_delegate = NewObject<UPythonHttpDelegate>();
+	py_delegate->SetPyCallable(py_callable);
+	// this trick avoids generating a new python object
+	py_delegate->SetPyHttpRequest(self);
+	self->http_request->OnProcessRequestComplete().BindUObject(py_delegate, &UPythonHttpDelegate::OnRequestComplete);
+
+	Py_INCREF(Py_None);
+	return Py_None;
+}
+
 static PyMethodDef ue_PyIHttpRequest_methods[] = {
+	{ "bind_on_process_request_complete", (PyCFunction)py_ue_ihttp_request_bind_on_process_request_complete, METH_VARARGS, "" },
 	{ "append_to_header", (PyCFunction)py_ue_ihttp_request_append_to_header, METH_VARARGS, "" },
 	{ "cancel_request", (PyCFunction)py_ue_ihttp_request_cancel_request, METH_VARARGS, "" },
 	{ "get_elapsed_time", (PyCFunction)py_ue_ihttp_request_get_elapsed_time, METH_VARARGS, "" },
@@ -150,7 +188,7 @@ static PyMethodDef ue_PyIHttpRequest_methods[] = {
 static PyObject *ue_PyIHttpRequest_str(ue_PyIHttpRequest *self)
 {
 	return PyUnicode_FromFormat("<unreal_engine.IHttpRequest '%p'>",
-		self->http_request.Get());
+		&self->http_request.Get());
 }
 
 static PyTypeObject ue_PyIHttpRequestType = {
@@ -213,6 +251,9 @@ void ue_python_init_ihttp_request(PyObject *ue_module) {
 
 	ue_PyIHttpRequestType.tp_base = &ue_PyIHttpBaseType;
 
+	ue_PyIHttpRequestType.tp_getattro = PyObject_GenericGetAttr;
+	ue_PyIHttpRequestType.tp_setattro = PyObject_GenericSetAttr;
+
 	if (PyType_Ready(&ue_PyIHttpRequestType) < 0)
 		return;
 

Source/UnrealEnginePython/Private/UEPyIHttpRequest.h

@@ -5,6 +5,8 @@
 #include "Runtime/Online/HTTP/Public/Interfaces/IHttpRequest.h"
 #include "Runtime/Online/HTTP/Public/HttpModule.h"
 
+#include "UEPyIHttpRequest.generated.h"
+
 
 struct ue_PyIHttpBaseType;
 
@@ -16,3 +18,23 @@ typedef struct {
 
 
 void ue_python_init_ihttp_request(PyObject *);
+
+UCLASS()
+class UPythonHttpDelegate : public UPythonDelegate
+{
+	GENERATED_BODY()
+
+public:
+	void OnRequestComplete(FHttpRequestPtr request, FHttpResponsePtr response, bool successful);
+
+	void SetPyHttpRequest(ue_PyIHttpRequest *request) {
+		py_http_request = request;
+		Py_INCREF(py_http_request);
+	}
+
+	~UPythonHttpDelegate() {
+		Py_XDECREF(py_http_request);
+	}
+protected:
+	ue_PyIHttpRequest *py_http_request;
+};

Source/UnrealEnginePython/Private/UEPyIHttpResponse.cpp

@@ -72,7 +72,6 @@ void ue_python_init_ihttp_response(PyObject *ue_module) {
 PyObject *py_ue_new_ihttp_response(IHttpResponse *response) {
 	ue_PyIHttpResponse *ret = (ue_PyIHttpResponse *)PyObject_New(ue_PyIHttpResponse, &ue_PyIHttpResponseType);
 	ret->http_response = response;
-	//TSharedRef<IHttpBase> ref(response);
-	//ret->base.http_base = ref;
+	ret->base.http_base = response;
 	return (PyObject *)ret;
 }

Source/UnrealEnginePython/Public/PythonDelegate.h

@@ -24,7 +24,7 @@ class UPythonDelegate : public UObject
 	void PyFOnAssetPostImport(UFactory *factory, UObject *u_object);
 #endif
 
-private:
+protected:
 	UFunction *signature;
 	bool signature_set;