Ensure link has href; Expand docs

Author: valentinogagliardi

.husky/pre-commit

@@ -2,3 +2,4 @@
 . "$(dirname "$0")/_/husky.sh"
 
 npm test
+npm run build:esm

README.md

@@ -24,7 +24,10 @@ import ResetViewControl from '@20tab/react-leaflet-resetview';
 const Map = () => {
     return (
         <MapContainer zoom={5} center={[-96.8716348, 32.8205866]}>
-            <ResetViewControl title="Reset view" />
+            <ResetViewControl 
+                title="Reset view"
+                icon="url(/some/relative/path.png)"
+            />
         </MapContainer>
     );
 };

__tests__/ResetViewControl.spec.tsx

@@ -53,4 +53,9 @@ describe("ResetViewControl", () => {
       "background-image": "url(/some/relative/path.png)",
     });
   });
+
+  test("link has href", () => {
+    render(<Map />);
+    expect(screen.getByTitle("Reset view")).toHaveAttribute("href", "#");
+  });
 });

src/ResetViewControl.ts

@@ -35,7 +35,16 @@ const _getControl = Control.extend({
 
     const container = DomUtil.create("div", "leaflet-bar");
     const link = DomUtil.create("a", "", container);
-    link.setAttribute("title", title);
+
+    const linkAttrs = {
+      title,
+      href: "#",
+    };
+
+    Object.entries(linkAttrs).forEach(([k, v]) => {
+      link.setAttribute(k, v);
+    });
+
     link.innerHTML = icon;
 
     if (RegExp(/url\(.+\)/).test(icon)) {