Lint and bug fixes

Author: 26zl

.github/workflows/ci.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: [main]
 
+permissions:
+  contents: read
+
 jobs:
   test:
     runs-on: ${{ matrix.os }}
@@ -24,7 +27,8 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.25'
+          go-version: '1.25.7'
+          cache-dependency-path: pygofastproxy/go/go.sum
 
       - name: Install package with test dependencies
         run: pip install -e ".[test]"

.github/workflows/lint.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: [main]
 
+permissions:
+  contents: read
+
 jobs:
   python-lint:
     runs-on: ubuntu-latest
@@ -32,7 +35,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.25'
+          go-version: '1.25.7'
 
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6

.github/workflows/security.yml

@@ -6,7 +6,10 @@ on:
   pull_request:
     branches: [main]
   schedule:
-    - cron: '0 8 * * 1' # Weekly on Monday
+    - cron: '0 8 * * 1'
+
+permissions:
+  contents: read
 
 jobs:
   go-vulncheck:
@@ -16,7 +19,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.25'
+          go-version: '1.25.7'
 
       - name: Install govulncheck
         run: go install golang.org/x/vuln/cmd/govulncheck@latest

benchmarks/benchmark.py

@@ -61,17 +61,15 @@ def run_benchmark(total_requests: int, concurrency: int):
     url = f"http://127.0.0.1:{proxy_port}/bench"
 
     # Warmup
-    print(f"Warming up with 200 requests...")
+    print("Warming up with 200 requests...")
     for _ in range(200):
         try:
             urllib.request.urlopen(url, timeout=5)
         except Exception:
             pass
 
     # Benchmark
-    print(
-        f"Benchmarking: {total_requests} requests, {concurrency} concurrent..."
-    )
+    print(f"Benchmarking: {total_requests} requests, {concurrency} concurrent...")
     successes = 0
     errors = 0
 
@@ -116,10 +114,18 @@ def make_request():
 def main():
     parser = argparse.ArgumentParser(description="Benchmark pygofastproxy")
     parser.add_argument(
-        "-n", "--requests", type=int, default=10000, help="Total requests (default: 10000)"
+        "-n",
+        "--requests",
+        type=int,
+        default=10000,
+        help="Total requests (default: 10000)",
     )
     parser.add_argument(
-        "-c", "--concurrency", type=int, default=50, help="Concurrent workers (default: 50)"
+        "-c",
+        "--concurrency",
+        type=int,
+        default=50,
+        help="Concurrent workers (default: 50)",
     )
     args = parser.parse_args()
     run_benchmark(args.requests, args.concurrency)

pygofastproxy/__init__.py

@@ -1,3 +1,3 @@
 from .runner import run_proxy
 
-__all__ = ["run_proxy"]
+__all__ = ["run_proxy"]

pygofastproxy/__main__.py

@@ -1,6 +1,8 @@
 """CLI entry point for pygofastproxy."""
+
 import os
 import sys
+
 from .runner import run_proxy
 
 

pygofastproxy/runner.py

@@ -4,14 +4,17 @@
 from pathlib import Path
 from urllib.parse import urlparse
 
+
 # Check if running on Windows.
 def _is_windows() -> bool:
     return os.name == "nt"
 
+
 # Return executable name, appending .exe on Windows.
 def _bin_name(base: str) -> str:
     return f"{base}.exe" if _is_windows() else base
 
+
 # Check if Go is installed and available in PATH.
 def check_go_installed():
     try:
@@ -24,32 +27,33 @@ def check_go_installed():
     except Exception as e:
         raise RuntimeError("Go is not installed or not found in PATH.") from e
 
+
 # Build the Go proxy binary from source.
 def build_proxy(go_dir: Path, binary_path: Path):
     print("Building Go proxy ...")
     if not (go_dir / "go.mod").exists():
         raise FileNotFoundError(f"Missing go.mod in {go_dir}")
 
     cmd = [
-        "go", "build",
+        "go",
+        "build",
         "-trimpath",
-        "-ldflags", "-s -w",
-        "-o", binary_path.name,
+        "-ldflags",
+        "-s -w",
+        "-o",
+        binary_path.name,
         ".",
     ]
     result = subprocess.run(
-        cmd,
-        cwd=go_dir,
-        stdout=subprocess.PIPE,
-        stderr=subprocess.STDOUT,
-        text=True
+        cmd, cwd=go_dir, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True
     )
     if result.returncode != 0:
         raise RuntimeError(f"Failed to build Go proxy:\n{result.stdout}")
 
     if not _is_windows():
         binary_path.chmod(0o755)
 
+
 # Check if the Go binary is missing or older than source files.
 def is_rebuild_needed(go_dir: Path, binary_file: Path) -> bool:
     if not binary_file.exists():
@@ -65,12 +69,13 @@ def is_rebuild_needed(go_dir: Path, binary_file: Path) -> bool:
             return True
     return False
 
+
 # Run the Go proxy, rebuilding if needed.
 def run_proxy(target="http://localhost:4000", port=8080, **kwargs):
     # Validate target URL
     try:
         parsed = urlparse(target)
-        if parsed.scheme not in ('http', 'https'):
+        if parsed.scheme not in ("http", "https"):
             raise ValueError(f"Target must use http or https scheme, got: {target}")
         if not parsed.netloc:
             raise ValueError(f"Invalid target URL (missing host): {target}")
@@ -116,7 +121,8 @@ def run_proxy(target="http://localhost:4000", port=8080, **kwargs):
     if "tls_key_file" in kwargs:
         env["PROXY_TLS_KEY_FILE"] = str(kwargs["tls_key_file"])
     if "cors_allow_credentials" in kwargs:
-        env["PROXY_CORS_ALLOW_CREDENTIALS"] = str(kwargs["cors_allow_credentials"]).lower()
+        val = str(kwargs["cors_allow_credentials"]).lower()
+        env["PROXY_CORS_ALLOW_CREDENTIALS"] = val
 
     print(f"Starting Go proxy at http://localhost:{port} -> {target}")
 
@@ -127,7 +133,7 @@ def run_proxy(target="http://localhost:4000", port=8080, **kwargs):
         env=env,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
-        text=True
+        text=True,
     )
 
     # Log output from the proxy process in a background thread.

test_functionality.py

@@ -76,7 +76,7 @@ def test_basic_proxy():
             # Test health endpoint
             health = requests.get(f"{base}/health", timeout=2)
             assert health.status_code == 200
-            
+
             # Test security headers
             assert "X-Content-Type-Options" in res.headers
             assert "X-Frame-Options" in res.headers

tests/conftest.py

@@ -21,9 +21,7 @@ def do_GET(self):
         self.send_response(200)
         self.send_header("Content-Type", "application/json")
         self.end_headers()
-        self.wfile.write(
-            b'{"method":"GET","path":"' + self.path.encode() + b'"}'
-        )
+        self.wfile.write(b'{"method":"GET","path":"' + self.path.encode() + b'"}')
 
     def do_POST(self):
         length = int(self.headers.get("Content-Length", 0))

tests/test_proxy.py

@@ -5,7 +5,6 @@
 
 from pygofastproxy.runner import run_proxy
 
-
 # ---------------------------------------------------------------------------
 # Basic proxy forwarding
 # ---------------------------------------------------------------------------
@@ -218,4 +217,4 @@ def test_port_too_high_raises(self):
 
     def test_port_not_int_raises(self):
         with pytest.raises(ValueError, match="Port"):
-            run_proxy(target="http://localhost:4000", port="abc")
+            run_proxy(target="http://localhost:4000", port="abc")  # type: ignore[arg-type]