fix algebrite. Tell user if site crashes

Author: 28raining

src/App.jsx

@@ -159,6 +159,7 @@ function App() {
   const [schemHistory, setSchemHistory] = useState({ pointer: 0, state: [modifiedSchematic] });
   const [urlSnackbar, setUrlSnackbar] = useState(false);
   const [errorSnackbar, setErrorSnackbar] = useState(false);
+  const [unsolveSnackbar, setUnsolveSnackbar] = useState(false);
 
   const handleSnackbarClick = () => {
     window.location.href = window.location.origin + window.location.pathname;
@@ -219,11 +220,30 @@ function App() {
     );
   }
 
+  function SnackbarUnsolvable() {
+    return (
+      <Snackbar
+        open={unsolveSnackbar}
+        autoHideDuration={10000}
+        onClose={() => setUnsolveSnackbar(false)}
+        anchorOrigin={{ vertical: "top", horizontal: "right" }}
+        message="This Snackbar will be dismissed in 5 seconds."
+      >
+        <SnackbarContent
+          message="The circuit seems to be unsolvable. Please double check your connections and try using Sympy if not already. Check the console for more details, and feel free to leave a comment."
+          sx={{
+            backgroundColor: "#ec1186ff",
+            color: "#fff",
+            maxWidth: 200,
+          }}
+        />
+      </Snackbar>
+    );
+  }
+
   const componentValuesSolved = {};
   for (const key in componentValues) componentValuesSolved[key] = componentValues[key].value * units[componentValues[key].type][componentValues[key].unit];
 
-  // const { freq_new, mag_new } = new_calculate_tf(results.complexResponse, fRange, settings.resolution, componentValuesSolved, errorSnackbar, () => setErrorSnackbar(true));
-
   const [freq_new, setFreqNew] = useState(null);
   const [mag_new, setMagNew] = useState(null);
   useEffect(() => {
@@ -275,6 +295,7 @@ function App() {
     <>
       <LetUserKnowAboutURL />
       <SnackbarError />
+      <SnackbarUnsolvable />
       <NavBar stateToURL={stateToURL} />
       <div className="w-100 p-2 bg-green pb-5" key="wrapper">
         {/* <div className="container-xl" key="topContainer"> */}
@@ -303,7 +324,13 @@ function App() {
             </div>
           </div>
           <div className="row shadow-sm rounded bg-lightgreen my-2 py-3" id="schematic">
-            <ChoseTF setResults={setResults} nodes={nodes} fullyConnectedComponents={fullyConnectedComponents} componentValuesSolved={componentValuesSolved} />
+            <ChoseTF
+              setResults={setResults}
+              nodes={nodes}
+              fullyConnectedComponents={fullyConnectedComponents}
+              componentValuesSolved={componentValuesSolved}
+              setUnsolveSnackbar={setUnsolveSnackbar}
+            />
             {results.text != "" && (
               <>
                 <DisplayMathML title="Laplace Transform" textResult={results.text} mathML={results.mathML} caclDone={results.text != ""} />

src/ChoseTF.jsx

@@ -26,7 +26,7 @@ function formatMathML(mathml, p, drivers) {
   return `<math><mfrac><mrow><mi>${p}</mi></mrow><mrow><msub><mi>${drivers[0] == "vin" ? "V" : "I"}</mi><mi>in</mi></msub></mrow></mfrac><mo>=</mo>${mathml}</math>`;
 }
 
-export function ChoseTF({ setResults, nodes, fullyConnectedComponents, componentValuesSolved }) {
+export function ChoseTF({ setResults, nodes, fullyConnectedComponents, componentValuesSolved, setUnsolveSnackbar }) {
   const [algebraic, setAlgebraic] = useState("algebrite");
   const [loading, setLoading] = useState(false);
   const [loadedPyo, setLoadedPyo] = useState(null);
@@ -87,6 +87,12 @@ export function ChoseTF({ setResults, nodes, fullyConnectedComponents, component
                       loadedPyo,
                       algebraic,
                     );
+                    if (textResult === "" && mathml === "" && complex_response === "") {
+                      setUnsolveSnackbar((x) => {
+                        if (!x) return true;
+                        else return x;
+                      });
+                    }
                     const editedMathMl = formatMathML(mathml, p, drivers);
                     const editedMathMlNumeric = formatMathML(numericResult, p, drivers);
                     setResults({

src/new_solveMNA.js

@@ -37,11 +37,16 @@ rx = Abs(result_numeric_complex)
 
 str(result_simplified), mathml(result_simplified, printer='presentation'), str(rx), mathml(result_numeric_simplified, printer='presentation'), str(result_numeric_simplified)
 `;
-  const [textResult, mathml, complex_response, numericML, numericText] = await pyodide.runPythonAsync(sympyString);
-  const newNumeric = numericML;
-  const newNumericText = numericText.replaceAll("**", "^");
+  try {
+    const [textResult, mathml, complex_response, numericML, numericText] = await pyodide.runPythonAsync(sympyString);
+    const newNumeric = numericML;
+    const newNumericText = numericText.replaceAll("**", "^");
 
-  return [textResult, removeFenced(mathml), complex_response, removeFenced(newNumeric), newNumericText];
+    return [textResult, removeFenced(mathml), complex_response, removeFenced(newNumeric), newNumericText];
+  } catch (err) {
+    console.log("Solving MNA matrix failed with this error:", err);
+    return ["", "", "", "", ""];
+  }
 }
 
 async function solveWithAlgebrite(matrixStr, mnaMatrix, resIndex, resIndex2) {
@@ -72,7 +77,6 @@ async function solveWithAlgebrite(matrixStr, mnaMatrix, resIndex, resIndex2) {
     return [textResult, mathml, complex_response];
   } catch (err) {
     console.log("Building MNA matrix failed with this error:", err);
-    //FIXME - show the toast
     return ["", "", ""];
   }
 }
@@ -203,7 +207,7 @@ export async function build_and_solve_mna(numNodes, chosenPlot, fullyConnectedCo
   var numericResult, textResult, mathml, complex_response, numericText;
 
   if (solver === "algebrite") {
-    [textResult, mathml, complex_response] = solveWithAlgebrite(nerdStr, mnaMatrix, resIndex, resIndex2);
+    [textResult, mathml, complex_response] = await solveWithAlgebrite(nerdStr, mnaMatrix, resIndex, resIndex2);
   } else {
     [textResult, mathml, complex_response, numericResult, numericText] = await solveWithSymPy(nerdStr, mnaMatrix, elementMap, resIndex, resIndex2, componentValuesSolved, pyodide);
   }

tests/circuit.test.js

@@ -36,10 +36,44 @@ test("voltage in current probe - 1", async () => {
   const [textResult, _mathml, complex_response, _numericResult, numericText] = await build_and_solve_mna(3, ["Y0"], components, values, pyodide, "sympy");
   expect(textResult).toEqual("C0*L0*s**2/(C0*L0*R0*s**2 + L0*s + R0)");
   // expect(_mathml).toEqual(null);
-  expect(complex_response).toEqual("C0*L0*s**2/sqrt(C0**2*L0**2*R0**2*s**4 - 2*C0*L0*R0**2*s**2 + L0**2*s**2 + R0**2)");
+  expect(complex_response).toEqual("1.0e-24*s**2/sqrt(1.0e-40*s**4 - 1.0e-20*s**2 + 1)");
   expect(numericText).toEqual("1.0e-20*s^2/(1.0e-16*s^2 + 1.0e-6*s + 10000)");
 });
 
+test("voltage in current probe (algebrite) - 1", async () => {
+  const components = {
+    Y0: {
+      ports: [0, 1],
+      type: "iprobe",
+    },
+    vin: {
+      ports: [0],
+      type: "vin",
+    },
+    L0: {
+      ports: [0, 2],
+      type: "inductor",
+    },
+    R0: {
+      ports: [1, 2],
+      type: "resistor",
+    },
+    C0: {
+      ports: [2, null],
+      type: "capacitor",
+    },
+  };
+  const values = {
+    L0: 0.000001,
+    R0: 10000,
+    C0: 1.0000000000000002e-14,
+  };
+  const [textResult, _mathml, complex_response] = await build_and_solve_mna(3, ["Y0"], components, values, null, "algebrite");
+  expect(textResult).toEqual("C0*L0*s^2/(R0+C0*L0*R0*s^2+L0*s)");
+  // expect(_mathml).toEqual(null);
+  expect(complex_response).toEqual("abs(C0)*abs(s)/((1-2*C0*R0^2/L0+C0^2*R0^2*s^2+R0^2/(L0^2*s^2))^(1/2))");
+});
+
 test("voltage in current probe - 2", async () => {
   const components = {
     R0: {
@@ -71,7 +105,7 @@ test("voltage in current probe - 2", async () => {
   const [textResult, _mathml, complex_response, _numericResult, numericText] = await build_and_solve_mna(3, ["Y0"], components, values, pyodide, "sympy");
   expect(textResult).toEqual("C0*L0*s**2/(C0*L0*R0*s**2 + L0*s + R0)");
   // expect(_mathml).toEqual(null);
-  expect(complex_response).toEqual("C0*L0*s**2/sqrt(C0**2*L0**2*R0**2*s**4 - 2*C0*L0*R0**2*s**2 + L0**2*s**2 + R0**2)");
+  expect(complex_response).toEqual("1.0e-24*s**2/sqrt(1.0e-40*s**4 - 1.0e-20*s**2 + 1)");
   expect(numericText).toEqual("1.0e-20*s^2/(1.0e-16*s^2 + 1.0e-6*s + 10000)");
 });
 
@@ -106,7 +140,7 @@ test("current in current probe - 2", async () => {
   const [textResult, _mathml, complex_response, _numericResult, numericText] = await build_and_solve_mna(3, ["Y0"], components, values, pyodide, "sympy");
   expect(textResult).toEqual("L0*s/(L0*s + R0)");
   // expect(_mathml).toEqual(null);
-  expect(complex_response).toEqual("L0*s/sqrt(L0**2*s**2 + R0**2)");
+  expect(complex_response).toEqual("1.0e-10*s/sqrt(1.0e-20*s**2 + 1)");
   expect(numericText).toEqual("1.0e-6*s/(1.0e-6*s + 10000)");
 });
 
@@ -136,7 +170,7 @@ test("current in current probe VCIS - 3", async () => {
   const [textResult, _mathml, complex_response, _numericResult, numericText] = await build_and_solve_mna(2, ["Y0"], components, values, pyodide, "sympy");
   expect(textResult).toEqual("G0*R0/(G0*R0 + 1)");
   // expect(_mathml).toEqual(null);
-  expect(complex_response).toEqual("G0*R0/(G0*R0 + 1)");
+  expect(complex_response).toEqual("0.999000999000999");
   expect(numericText).toEqual("0.999000999000999");
 });
 
@@ -176,6 +210,6 @@ test("voltage in voltage probe VCVS", async () => {
   const [textResult, _mathml, complex_response, _numericResult, numericText] = await build_and_solve_mna(3, ["X0"], components, values, pyodide, "sympy");
   expect(textResult).toEqual("A0*R0*(C0*L0*s**2 + 1)/(C0*L0*R0*s**2 + L0*s + R0)");
   // expect(_mathml).toEqual(null);
-  expect(complex_response).toEqual("Abs(A0*C0*L0*R0*s**2 - A0*R0)/sqrt(C0**2*L0**2*R0**2*s**4 - 2*C0*L0*R0**2*s**2 + L0**2*s**2 + R0**2)"); //FIXME - this seems to be a sympy bug
+  expect(complex_response).toEqual("Abs(1.0e-13*s**2 - 100000000)/(1000000*sqrt(1.0e-42*s**4 - 1.999999999e-21*s**2 + 1))"); //FIXME - this seems to be a sympy bug
   expect(numericText).toEqual("(1.0e-13*s^2 + 100000000)/(1.0e-15*s^2 + 1.0e-9*s + 1000000)");
 });

toDo.md

@@ -1,4 +1,7 @@
-#visiojs todo
+# Todo Oct 23rd
+- Update all the packages - once Sympy 1.13.4 is integrated to Pyodide!
+
+# visiojs todo
 
 - delete wire, redraw wire, then undo breaks
 - Move the matrix solver into a web worker. So if can be killed with a timeout
@@ -26,6 +29,13 @@
 
 - if add op amp with zero on input and LC on output, and change input to current source, it crashes
 
+# Done October 2025
+
+- Fix Algebrite which got broken when Sympy moved to async function
+- Fix self testing which got broken when numeric solving moved from js to sympy
+- Add an algebrite case to self testing
+- If Sympy crashes, don't hang for ever, feed it back to the user. It does this with a Toast
+
 # Done on Jan 28th
 
 - handle errors in calculate mna better