Skip to content

Commit 4df5551

Browse files
authored
Merge pull request #2936 from GreenestBeen/bump-py-main
Add version diff handling
2 parents ee8955b + 0d6547e commit 4df5551

File tree

4 files changed

+27
-3
lines changed

4 files changed

+27
-3
lines changed

ap_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
"""Holds the version for Archipelago."""
22

3-
version = "1.0.55"
3+
version = "1.0.56"

archipelago.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"minimum_ap_version": "0.6.5",
3+
"world_version": "1.0.56",
4+
"authors": ["2dos", "AlmostSeagull", "Ballaam", "Green Bean", "Killklli", "Lrauq", "PoryGone", "Umed"],
5+
"version": 7,
6+
"compatible_version": 7,
7+
"game": "Donkey Kong 64"
8+
}

archipelago/DK64Client.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,22 @@ def on_package(self, cmd: str, args: dict):
752752
if cmd == "Connected":
753753
self.game = self.slot_info[self.slot].game
754754
self.slot_data = args.get("slot_data", {})
755+
if self.slot_data.get("Version"):
756+
server_ver = self.slot_data.get("Version")
757+
server_major = server_ver.split(".")[0]
758+
server_minor = server_ver.split(".")[1]
759+
server_patch = server_ver.split(".")[2]
760+
# Get the current version from the ap_version.py file
761+
ap_major = ap_version.split(".")[0]
762+
ap_minor = ap_version.split(".")[1]
763+
ap_patch = ap_version.split(".")[2]
764+
if server_major != ap_major or server_minor != ap_minor:
765+
logger.error("Your DK64 APworld does not match with the generated world.")
766+
logger.error(f"Your version: {ap_version} | Generated version: {server_ver}")
767+
raise Exception("Your DK64 APworld does not match with the generated world.\n" + f"Your version: {ap_version} | Generated version: {server_ver}")
768+
if server_patch != ap_patch:
769+
logger.warning("Your DK64 APworld does not match with the generated world, but this should not be a breaking change.")
770+
logger.warning("While we try to maintain backwards compatibility on patch versions, be warned that something might break.")
755771
if self.slot_data.get("death_link"):
756772
if "DeathLink" not in self.tags:
757773
create_task_log_exception(self.update_death_link(True))

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
pyxdelta==0.2.0
2-
pillow==10.3.0
1+
pyxdelta==0.2.2
2+
pillow==11.3.0

0 commit comments

Comments
 (0)