-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Description
Important
Follow-on from #6941
This PR jupyterhub/zero-to-jupyterhub-k8s#3690 adds support for dict-based configuration of list items in zero-to-jupyterhub-k8s. It is not exhaustive, and in particular does not add this option to profile list definitions.
In a recent conversation about how to design hubs, @yuvipanda confirmed that we want to lift as much configuration into common configuration files (per cluster) as possible. By adding support for defining profile lists as dictionaries, it will be possible to define extensible profile lists in the common configuration.
Steps
- Modify the
profile_listschema to accept a dictionary of dictionaries, or array of dictionaries. - Add handling logic to
jupyterhub_config.py(e.g. https://github.com/sunu/zero-to-jupyterhub-k8s/blob/9fca3ce184d161483fa62c87d7a5c41f6dc15a5a/jupyterhub/files/hub/jupyterhub_config.py#L343-L348) - Add test to ensure this new config works
- Update z2jh docs to reflect this new capability
Definition of Done
- A PR has been authored that adds support for dict-based profile lists
- The PR has been tested
- The PR has been reviewed
- The PR has docs
- An issue has been created to track applying this change to our clusters
Metadata
Metadata
Assignees
Labels
No labels