Review https://github.com/jupyterhub/configurable-http-proxy/pull/592

[agoose77]

jupyterhub/configurable-http-proxy#592 is a small PR to add unix socket support. It aligns with unix socket support in JupyterHub.

EDIT: PR already merged without my review -- let's follow up with jupyterhub/configurable-http-proxy#597 (review)

Definition of done

• the PR is reviewed
• the PR is merged

[agoose77]

I looked at this PR, and it's pretty straightforward -- it passes through support in the underlying http-proxy-3 library for UNIX sockets.

JupyterHub also supports binding to a UNIX socket, and this PR uses the same scheme (unix+http). HTTPS is not supported; I don't think SSL over AF_UNIX is particular widespread, and I couldn't find many standardised approaches. I think that's fine -- these are fairly different concerns.

I've made some edits to improve the PR, but I don't have push rights. I'll touch base with e.g. @yuvi to merge these in.

[agoose77]

I have a branch here — @yuvipanda are you happy to push those to the PR (you should be able to): https://github.com/agoose77/configurable-http-proxy/tree/connect_to_unix_socket

[agoose77]

This is blocked on needing a second pair of eyes, ideally, to review @yuvipanda hopefully can get to this next week. Or, we push it off -- it's not a priority imo given how much other critical things are happening at the moment.

[yuvipanda]

@agoose77 looks like that PR was merged without your changes. Can you make another PR with just your changes?

[agoose77]

Ugh, so it was. I'll rebase and create a new pr!

[agoose77]

@yuvipanda I've added my commits here: jupyterhub/configurable-http-proxy#597

[yuvipanda]

Looks like this was merged. Thanks @agoose77!