Update planarity source files #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejo7797
force-pushed
the
planarity-update
branch
from
15219af to
af07124
Compare
Member
|
@alejo7797 Thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #65.
The places to focus on are:
planarity_src/fetch_planarity.sh, which I encourage you to look at and run on your end to see that the new planarity source files are indeed copied from upstream,setup.pyandMANIFEST.in, which I had to tweak since many of the new C source files and headers are now in subdirectories ofplanarity_src/c.I have tested running SnapPy against this new build of Spherogram and things seem to work (at least the tests don't complain).