Skip to content

Commit d1f9b61

Browse files
authored
Merge pull request #31 from 3D-e-Chem/deprecate-py
Deprecate py
2 parents 28089f6 + 36b683e commit d1f9b61

33 files changed

+98
-48
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ The file is formatted as described on http://keepachangelog.com/.
55

66
## Unreleased
77

8+
## [2.5.0] - 2019-09-25
9+
10+
### Deprecated
11+
12+
- Python based nodes in favour of web service nodes ([#25](https://github.com/3D-e-Chem/knime-kripodb/issues/25))
13+
814
## [2.4.2] - 2019-07-02
915

1016
### Changed

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ Requirements:
1919
Optionally:
2020

2121
* KripoDB Python package & data files, https://github.com/3D-e-Chem/kripodb,
22-
required when nodes which use local Kripo files are used.
23-
Nodes which talk to web service work without the KripoDB Python package.
22+
required to start local running kripo web service instead of the public [one](http://3d-e-chem.vu-compmedchem.nl/kripodb/ui).
2423

2524
Steps to get KripoDB nodes inside KNIME:
2625

@@ -39,8 +38,6 @@ The workflow can be run by importing it into KNIME as an archive.
3938

4039
Other workflows using the KripoDB nodes can be found at https://github.com/3D-e-Chem/workflows
4140

42-
Make sure the Python used by KNIME is the same the Python with kripodb package installed.
43-
4441
# Development
4542

4643
Development requirements:
@@ -54,6 +51,7 @@ Steps to get development environment setup based on https://github.com/knime/kni
5451
3. Configure Java 8 inside Eclipse Window > Preferences > Java > Installed JREs
5552
4. Import this repo as an Existing Maven project
5653
5. Activate target platform by going to Window > Preferences > Plug-in Development > Target Platform and check the `KNIME Analytics Platform (4.0) - nl.esciencecenter.e3dchem.kripodb.targetplatform/KNIME-AP-4.0.target` target definition.
54+
6. A KNIME Analytics Platform instance can be started by right clicking on the `targetplatform/KNIME\ Analytics\ Platform.launch` file and selecting `Run As → KNIME Analytics Platform`. The KNIME instance will contain the target platform together with all extensions defined in the workspace.
5755

5856
During import the Tycho Eclipse providers must be installed.
5957

50.7 KB
Binary file not shown.

examples/Knime-KripoDB-example.zip

-70.4 KB
Binary file not shown.

feature/feature.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<feature
33
id="nl.esciencecenter.e3dchem.kripodb.feature"
44
label="KripoDB nodes for KNIME"
5-
version="2.4.2.qualifier"
5+
version="2.5.0.qualifier"
66
provider-name="Netherlands eScience Center">
77

88
<description url="https://github.com/3D-e-Chem/knime-kripodb">

feature/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>nl.esciencecenter.e3dchem.kripodb</groupId>
88
<artifactId>nl.esciencecenter.e3dchem.kripodb</artifactId>
9-
<version>2.4.2-SNAPSHOT</version>
9+
<version>2.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>nl.esciencecenter.e3dchem.kripodb.feature</artifactId>

p2/category.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<site>
3-
<feature id="nl.esciencecenter.e3dchem.kripodb.feature" version="2.4.2.qualifier">
3+
<feature id="nl.esciencecenter.e3dchem.kripodb.feature" version="2.5.0.qualifier">
44
<category name="nl.esciencecenter.3D-e-Chem"/>
55
</feature>
66
<category-def name="nl.esciencecenter.3D-e-Chem" label="KNIME 3D-e-Chem Contributions">

p2/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<parent>
44
<artifactId>nl.esciencecenter.e3dchem.kripodb</artifactId>
55
<groupId>nl.esciencecenter.e3dchem.kripodb</groupId>
6-
<version>2.4.2-SNAPSHOT</version>
6+
<version>2.5.0-SNAPSHOT</version>
77
</parent>
88
<artifactId>nl.esciencecenter.e3dchem.kripodb.p2</artifactId>
99
<packaging>eclipse-repository</packaging>

plugin/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: 3D-e-Chem KNIME KripoDB nodes
44
Bundle-SymbolicName: nl.esciencecenter.e3dchem.kripodb.plugin;singleton:=true
5-
Bundle-Version: 2.4.2.qualifier
5+
Bundle-Version: 2.5.0.qualifier
66
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
77
Bundle-Activator: nl.esciencecenter.e3dchem.kripodb.Activator
88
Require-Bundle: org.knime.core;bundle-version="[4.0.0,5.0.0)",

plugin/plugin.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,17 @@
3636
</node>
3737
<node
3838
category-path="/community/3d-e-chem/kripodb/local"
39-
deprecated="false"
39+
deprecated="true"
4040
factory-class="nl.esciencecenter.e3dchem.kripodb.fragmentsbysimilarity.FragmentBySimilarityFactory">
4141
</node>
4242
<node
4343
category-path="/community/3d-e-chem/kripodb/local"
44-
deprecated="false"
44+
deprecated="true"
4545
factory-class="nl.esciencecenter.e3dchem.kripodb.fragments.FragmentByIdFactory">
4646
</node>
4747
<node
4848
category-path="/community/3d-e-chem/kripodb/local"
49-
deprecated="false"
49+
deprecated="true"
5050
factory-class="nl.esciencecenter.e3dchem.kripodb.local.pharmacophores.PharmacophoresFactory">
5151
</node>
5252
</extension>

0 commit comments

Comments
 (0)