Skip to content

Commit 852ccf0

Browse files
committed
Simplify getting visible property, it's okay to always use entity.object3D.visible
1 parent 78de8e4 commit 852ccf0

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/editor/components/scenegraph/Entity.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@ export default class Entity extends React.Component {
2525

2626
toggleVisibility = () => {
2727
const entity = this.props.entity;
28-
const visible =
29-
entity.tagName.toLowerCase() === 'a-scene'
30-
? entity.object3D.visible
31-
: entity.getAttribute('visible');
28+
const visible = entity.object3D.visible;
3229
AFRAME.INSPECTOR.execute('entityupdate', {
3330
entity,
3431
component: 'visible',
@@ -82,10 +79,7 @@ export default class Entity extends React.Component {
8279
}
8380

8481
// Visibility button.
85-
const visible =
86-
tagName === 'a-scene'
87-
? entity.object3D.visible
88-
: entity.getAttribute('visible');
82+
const visible = entity.object3D.visible;
8983
const visibilityButton = (
9084
<i
9185
title="Toggle entity visibility"

0 commit comments

Comments
 (0)