Skip to content

Commit a5a73cb

Browse files
authored
Fix typos in GLSL comments and add constants PURE_RED, PURE_GREEN, PURE_BLUE (#2340)
* Fix typos in GLSL comments * Fix typos in GLSL comments * add constants PURE_RED, PURE_GREEN, PURE_BLUE
1 parent bd8d2fb commit a5a73cb

File tree

5 files changed

+9
-3
lines changed

5 files changed

+9
-3
lines changed

manimlib/constants.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,9 @@
130130
LIGHT_PINK: ManimColor = manim_config.colors.light_pink
131131
GREEN_SCREEN: ManimColor = manim_config.colors.green_screen
132132
ORANGE: ManimColor = manim_config.colors.orange
133+
PURE_RED: ManimColor = manim_config.colors.pure_red
134+
PURE_GREEN: ManimColor = manim_config.colors.pure_green
135+
PURE_BLUE: ManimColor = manim_config.colors.pure_blue
133136

134137
MANIM_COLORS: List[ManimColor] = list(manim_config.colors.values())
135138

manimlib/default_config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ colors:
169169
light_pink: "#DC75CD"
170170
green_screen: "#00FF00"
171171
orange: "#FF862F"
172+
pure_red: "#FF0000"
173+
pure_green: "#00FF00"
174+
pure_blue: "#0000FF"
172175
# Can be DEBUG / INFO / WARNING / ERROR / CRITICAL
173176
log_level: "INFO"
174177
universal_import_line: "from manimlib import *"

manimlib/shaders/inserts/emit_gl_Position.glsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ uniform vec4 clip_plane;
66

77
void emit_gl_Position(vec3 point){
88
vec4 result = vec4(point, 1.0);
9-
// This allow for smooth transitions between objects fixed and unfixed from frame
9+
// This allows for smooth transitions between objects fixed and unfixed from frame
1010
result = mix(view * result, result, is_fixed_in_frame);
1111
// Essentially a projection matrix
1212
result.xyz *= frame_rescale_factors;

manimlib/shaders/inserts/finalize_color.glsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ vec4 add_light(vec4 color, vec3 point, vec3 unit_normal){
2727
float light_to_normal = dot(to_light, unit_normal);
2828
// When unit normal points towards light, brighten
2929
float bright_factor = max(light_to_normal, 0) * reflectiveness;
30-
// For glossy surface, add extra shine if light beam go towards camera
30+
// For glossy surface, add extra shine if light beam goes towards camera
3131
vec3 light_reflection = reflect(-to_light, unit_normal);
3232
float light_to_cam = dot(light_reflection, to_camera);
3333
float shine = gloss * exp(-3 * pow(1 - light_to_cam, 2));

manimlib/shaders/true_dot/frag.glsl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ in vec2 uv_coords;
1313

1414
out vec4 frag_color;
1515

16-
// This include a delaration of uniform vec3 shading
16+
// This includes a declaration of uniform vec3 shading
1717
#INSERT finalize_color.glsl
1818

1919
void main() {

0 commit comments

Comments
 (0)