Update ABI strategy errors and log level (#236)

anastasiarods · web-flow · commit 7a408f81daa7 · 2025-06-13T16:18:06.000+02:00
diff --git a/.changeset/silver-gifts-chew.md b/.changeset/silver-gifts-chew.md
@@ -0,0 +1,5 @@
+---
+'@3loop/transaction-decoder': patch
+---
+
+Update ABI strategy errors and log levels
diff --git a/packages/transaction-decoder/src/abi-loader.ts b/packages/transaction-decoder/src/abi-loader.ts
@@ -202,7 +202,7 @@ export const AbiLoaderRequestResolver = RequestResolver.makeBatched((requests: A
             strategyId: 'address-batch',
           })
           .pipe(
-            Effect.tapError(Effect.logWarning),
+            Effect.tapError(Effect.logDebug),
             Effect.orElseSucceed(() => null),
             Effect.map((result) => (result ? Either.left(result) : Either.right(req))),
           )
@@ -234,7 +234,7 @@ export const AbiLoaderRequestResolver = RequestResolver.makeBatched((requests: A
             strategyId: 'fragment-batch',
           })
           .pipe(
-            Effect.tapError(Effect.logWarning),
+            Effect.tapError(Effect.logDebug),
             Effect.orElseSucceed(() => null),
           ) // If no strategies found, return null
       },
diff --git a/packages/transaction-decoder/src/abi-strategy/blockscout-abi.ts b/packages/transaction-decoder/src/abi-strategy/blockscout-abi.ts
@@ -91,7 +91,9 @@ export const BlockscoutStrategyResolver = (config: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.BlockscoutStrategyResolver',
diff --git a/packages/transaction-decoder/src/abi-strategy/etherscan-abi.ts b/packages/transaction-decoder/src/abi-strategy/etherscan-abi.ts
@@ -136,7 +136,9 @@ export const EtherscanStrategyResolver = (config?: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.EtherscanStrategyResolver',
diff --git a/packages/transaction-decoder/src/abi-strategy/etherscanv2-abi.ts b/packages/transaction-decoder/src/abi-strategy/etherscanv2-abi.ts
@@ -99,7 +99,9 @@ export const EtherscanV2StrategyResolver = (config?: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.EtherscanV2StrategyResolver',
diff --git a/packages/transaction-decoder/src/abi-strategy/experimental-erc20.ts b/packages/transaction-decoder/src/abi-strategy/experimental-erc20.ts
@@ -6,13 +6,15 @@ import { erc20Abi, getAddress, getContract } from 'viem'
 const getLocalFragments = (service: PublicClient, { address, chainId }: RequestModel.GetContractABIStrategyParams) =>
   Effect.gen(function* () {
     if (!address)
-      return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId))
+      return yield* Effect.fail(
+        new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, 'Address is required'),
+      )
 
     const client = yield* service
       .getPublicClient(chainId)
       .pipe(
-        Effect.catchAll(() =>
-          Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId)),
+        Effect.catchAll((e) =>
+          Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e))),
         ),
       )
 
@@ -23,14 +25,12 @@ const getLocalFragments = (service: PublicClient, { address, chainId }: RequestM
           address: getAddress(address),
           client: client.client,
         }),
-      catch: () => {
-        throw new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId)
-      },
+      catch: (e) => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e)),
     })
 
     const decimals = yield* Effect.tryPromise({
       try: () => inst.read.decimals(),
-      catch: () => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId),
+      catch: (e) => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e)),
     })
 
     if (decimals != null) {
diff --git a/packages/transaction-decoder/src/abi-strategy/fourbyte-abi.ts b/packages/transaction-decoder/src/abi-strategy/fourbyte-abi.ts
@@ -119,7 +119,12 @@ export const FourByteStrategyResolver = (): RequestModel.ContractAbiResolverStra
             )
           } else {
             return yield* Effect.fail(
-              new RequestModel.ResolveStrategyABIError('4byte.directory', req.address, req.chainId),
+              new RequestModel.ResolveStrategyABIError(
+                '4byte.directory',
+                req.address,
+                req.chainId,
+                String(result.cause),
+              ),
             )
           }
         }),
diff --git a/packages/transaction-decoder/src/abi-strategy/openchain-abi.ts b/packages/transaction-decoder/src/abi-strategy/openchain-abi.ts
@@ -136,7 +136,9 @@ export const OpenchainStrategyResolver = (): RequestModel.ContractAbiResolverStr
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.OpenchainStrategyResolver',
diff --git a/packages/transaction-decoder/src/abi-strategy/request-model.ts b/packages/transaction-decoder/src/abi-strategy/request-model.ts
@@ -1,4 +1,4 @@
-import { Effect, RateLimiter } from 'effect'
+import { Data, Effect, RateLimiter } from 'effect'
 
 export interface FetchABIParams {
   readonly chainID: number
@@ -7,25 +7,35 @@ export interface FetchABIParams {
   readonly signature?: string | undefined
 }
 
-export class ResolveStrategyABIError {
-  readonly _tag = 'ResolveStrategyABIError'
-  constructor(
-    readonly resolverName: string,
-    readonly address: string,
-    readonly chain: number,
-  ) {}
+export class ResolveStrategyABIError extends Data.TaggedError('ResolveStrategyABIError')<{
+  resolver: string
+  address: string
+  chainID: number
+  message: string
+}> {
+  constructor(resolver: string, address: string, chainID: number, message: string) {
+    super({ resolver, address, chainID, message })
+  }
 }
 
-export class MissingABIStrategyError {
-  readonly _tag = 'MissingABIStrategyError'
+export class MissingABIStrategyError extends Data.TaggedError('MissingABIStrategyError')<{
+  address: string
+  chainId: number
+  strategyId: string
+  event?: string
+  signature?: string
+  message: string
+}> {
   constructor(
-    readonly address: string,
-    readonly chainId: number,
-    readonly strategyId: string,
-    readonly event?: string,
-    readonly signature?: string,
-    readonly message: string = 'Missing contract ABI',
-  ) {}
+    address: string,
+    chainId: number,
+    strategyId: string,
+    event?: string,
+    signature?: string,
+    message = 'Missing contract ABI',
+  ) {
+    super({ address, chainId, strategyId, event, signature, message })
+  }
 }
 
 interface FunctionFragmentABI {
diff --git a/packages/transaction-decoder/src/abi-strategy/sourcify-abi.ts b/packages/transaction-decoder/src/abi-strategy/sourcify-abi.ts
@@ -96,7 +96,9 @@ export const SourcifyStrategyResolver = (): RequestModel.ContractAbiResolverStra
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.SourcifyStrategyResolver',
diff --git a/packages/transaction-decoder/src/abi-strategy/strategy-executor.ts b/packages/transaction-decoder/src/abi-strategy/strategy-executor.ts
@@ -21,7 +21,7 @@ export const make = (circuitBreaker: CircuitBreaker, requestPool: RequestPool) =
       Effect.catchTag('MissingABIStrategyError', (error) => {
         // Log error but don't fail the entire operation
         return Effect.gen(function* () {
-          yield* Effect.logWarning(`Strategy ${strategy.id} found no ABI: ${error.message}`)
+          yield* Effect.logDebug(`Strategy ${strategy.id} found no ABI: ${error.message}`)
           return yield* Effect.succeed(error)
         })
       }),
diff --git a/packages/transaction-decoder/src/contract-meta-loader.ts b/packages/transaction-decoder/src/contract-meta-loader.ts
@@ -150,7 +150,7 @@ const ContractMetaLoaderRequestResolver = RequestResolver.makeBatched((requests:
             strategyId: 'meta-batch',
           })
           .pipe(
-            Effect.tapError(Effect.logWarning),
+            Effect.tapError(Effect.logDebug),
             Effect.orElseSucceed(() => null),
           )
       },
diff --git a/packages/transaction-decoder/src/meta-strategy/strategy-executor.ts b/packages/transaction-decoder/src/meta-strategy/strategy-executor.ts
@@ -34,7 +34,7 @@ export const make = (circuitBreaker: CircuitBreaker, requestPool: RequestPool) =
       // Treate MissingMetaError as a success for circuit breaker
       Effect.catchTag('MissingMetaError', (error) => {
         return Effect.gen(function* () {
-          yield* Effect.logWarning(`Meta strategy ${strategy.id} found no metadata: ${error.message}`)
+          yield* Effect.logDebug(`Meta strategy ${strategy.id} found no metadata: ${error.message}`)
           return yield* Effect.succeed(error)
         })
       }),

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@3loop/transaction-decoder': patch
 +---
++
 +Update ABI strategy errors and log levels
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,9 @@ export const BlockscoutStrategyResolver = (config: {`
`91`	`91`	`),`
`92`	`92`	`)`
`93`	`93`	`} else {`
`94`		`- return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId))`
	`94`	`+ return yield* Effect.fail(`
	`95`	`+ new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId, String(result.cause)),`
	`96`	`+ )`
`95`	`97`	`}`
`96`	`98`	`}),`
`97`	`99`	`'AbiStrategy.BlockscoutStrategyResolver',`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@ export const EtherscanStrategyResolver = (config?: {`
`136`	`136`	`),`
`137`	`137`	`)`
`138`	`138`	`} else {`
`139`		`- return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId))`
	`139`	`+ return yield* Effect.fail(`
	`140`	`+ new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId, String(result.cause)),`
	`141`	`+ )`
`140`	`142`	`}`
`141`	`143`	`}),`
`142`	`144`	`'AbiStrategy.EtherscanStrategyResolver',`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,9 @@ export const EtherscanV2StrategyResolver = (config?: {`
`99`	`99`	`),`
`100`	`100`	`)`
`101`	`101`	`} else {`
`102`		`- return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId))`
	`102`	`+ return yield* Effect.fail(`
	`103`	`+ new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId, String(result.cause)),`
	`104`	`+ )`
`103`	`105`	`}`
`104`	`106`	`}),`
`105`	`107`	`'AbiStrategy.EtherscanV2StrategyResolver',`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,12 @@ export const FourByteStrategyResolver = (): RequestModel.ContractAbiResolverStra`
`119`	`119`	`)`
`120`	`120`	`} else {`
`121`	`121`	`return yield* Effect.fail(`
`122`		`- new RequestModel.ResolveStrategyABIError('4byte.directory', req.address, req.chainId),`
	`122`	`+ new RequestModel.ResolveStrategyABIError(`
	`123`	`+ '4byte.directory',`
	`124`	`+ req.address,`
	`125`	`+ req.chainId,`
	`126`	`+ String(result.cause),`
	`127`	`+ ),`
`123`	`128`	`)`
`124`	`129`	`}`
`125`	`130`	`}),`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,9 @@ export const OpenchainStrategyResolver = (): RequestModel.ContractAbiResolverStr`
`136`	`136`	`),`
`137`	`137`	`)`
`138`	`138`	`} else {`
`139`		`- return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId))`
	`139`	`+ return yield* Effect.fail(`
	`140`	`+ new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId, String(result.cause)),`
	`141`	`+ )`
`140`	`142`	`}`
`141`	`143`	`}),`
`142`	`144`	`'AbiStrategy.OpenchainStrategyResolver',`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,9 @@ export const SourcifyStrategyResolver = (): RequestModel.ContractAbiResolverStra`
`96`	`96`	`),`
`97`	`97`	`)`
`98`	`98`	`} else {`
`99`		`- return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId))`
	`99`	`+ return yield* Effect.fail(`
	`100`	`+ new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId, String(result.cause)),`
	`101`	`+ )`
`100`	`102`	`}`
`101`	`103`	`}),`
`102`	`104`	`'AbiStrategy.SourcifyStrategyResolver',`