Differentiate from missing and error in strategies

Author: Ferossgp

packages/transaction-decoder/src/abi-strategy/request-model.ts

@@ -16,6 +16,18 @@ export class ResolveStrategyABIError {
   ) {}
 }
 
+export class MissingABIError {
+  readonly _tag = 'MissingABIError'
+  constructor(
+    readonly address: string,
+    readonly chainId: number,
+    readonly strategyId: string,
+    readonly event?: string,
+    readonly signature?: string,
+    readonly message: string = 'Missing contract ABI',
+  ) {}
+}
+
 interface FunctionFragmentABI {
   type: 'func'
   abi: string
@@ -47,7 +59,7 @@ export interface ContractAbiResolverStrategy {
   type: 'address' | 'fragment'
   id: string
   rateLimit?: RateLimiterOptions
-  resolver: (_: GetContractABIStrategyParams) => Effect.Effect<ContractABI[], ResolveStrategyABIError>
+  resolver: (_: GetContractABIStrategyParams) => Effect.Effect<ContractABI[], ResolveStrategyABIError | MissingABIError>
 }
 
 export interface GetContractABIStrategyParams {

packages/transaction-decoder/src/abi-strategy/strategy-executor.ts

@@ -1,5 +1,5 @@
 import { Effect, Schedule, Duration, pipe, Data } from 'effect'
-import { GetContractABIStrategyParams, ContractAbiResolverStrategy } from '../abi-strategy/request-model.js'
+import { GetContractABIStrategyParams, ContractAbiResolverStrategy, MissingABIError } from './request-model.js'
 import type { CircuitBreaker } from '../circuit-breaker/circuit-breaker.js'
 import { RequestPool } from '../circuit-breaker/request-pool.js'
 import * as Constants from '../circuit-breaker/constants.js'
@@ -23,15 +23,16 @@ export const make = (circuitBreaker: CircuitBreaker, requestPool: RequestPool) =
           Schedule.compose(Schedule.recurs(Constants.DEFAULT_RETRY_TIMES)),
         ),
       ),
-      (effect) => circuitBreaker.withCircuitBreaker(strategy.id, effect),
-      (effect) => requestPool.withPoolManagement(params.chainId, effect),
-      Effect.catchAll((error) => {
+      Effect.catchTag('MissingABIError', (error) => {
         // Log error but don't fail the entire operation
         return Effect.gen(function* () {
-          yield* Effect.logWarning(`Strategy ${strategy.id} failed: ${JSON.stringify(error)}`)
-          return yield* Effect.fail(error)
+          yield* Effect.logWarning(`Strategy ${strategy.id} found no ABI: ${error.message}`)
+          return yield* Effect.succeed(error)
         })
       }),
+      (effect) => circuitBreaker.withCircuitBreaker(strategy.id, effect),
+      (effect) => requestPool.withPoolManagement(params.chainId, effect),
+      Effect.flatMap((data) => (data instanceof MissingABIError ? Effect.fail(data) : Effect.succeed(data))),
     )
   }
 

packages/transaction-decoder/src/meta-strategy/request-model.ts

@@ -18,6 +18,16 @@ export class ResolveStrategyMetaError {
   ) {}
 }
 
+export class MissingMetaError {
+  readonly _tag = 'MissingMetaError'
+  constructor(
+    readonly address: Address,
+    readonly chainId: number,
+    readonly strategyId: string,
+    readonly message: string = 'Missing contract metadata',
+  ) {}
+}
+
 export interface ContractMetaResolverStrategy {
   id: string
   resolver: RequestResolver.RequestResolver<GetContractMetaStrategy, never>
@@ -32,6 +42,7 @@ export class GetContractMetaStrategy extends Schema.TaggedRequest<GetContractMet
       Schema.instanceOf(ResolveStrategyMetaError),
       Schema.instanceOf(UnknownNetwork),
       Schema.instanceOf(RPCFetchError),
+      Schema.instanceOf(MissingMetaError),
     ),
     success: SchemaContractData,
     payload: {

packages/transaction-decoder/src/meta-strategy/strategy-executor.ts

@@ -1,5 +1,10 @@
 import { Effect, Schedule, Duration, pipe, Data } from 'effect'
-import { FetchMetaParams, ContractMetaResolverStrategy, GetContractMetaStrategy } from './request-model.js'
+import {
+  FetchMetaParams,
+  ContractMetaResolverStrategy,
+  GetContractMetaStrategy,
+  MissingMetaError,
+} from './request-model.js'
 import type { CircuitBreaker } from '../circuit-breaker/circuit-breaker.js'
 import { RequestPool } from '../circuit-breaker/request-pool.js'
 import * as Constants from '../circuit-breaker/constants.js'
@@ -31,15 +36,16 @@ export const make = (circuitBreaker: CircuitBreaker, requestPool: RequestPool) =
           Schedule.compose(Schedule.recurs(Constants.DEFAULT_RETRY_TIMES)),
         ),
       ),
-      (effect) => circuitBreaker.withCircuitBreaker(strategy.id, effect),
-      (effect) => requestPool.withPoolManagement(params.chainId, effect),
-      Effect.catchAll((error) => {
-        // Log error but don't fail the entire operation
+      // Treate MissingMetaError as a success for circuit breaker
+      Effect.catchTag('MissingMetaError', (error) => {
         return Effect.gen(function* () {
-          yield* Effect.logWarning(`Meta strategy ${strategy.id} failed: ${JSON.stringify(error)}`)
-          return yield* Effect.fail(error)
+          yield* Effect.logWarning(`Meta strategy ${strategy.id} found no metadata: ${error.message}`)
+          return yield* Effect.succeed(error)
         })
       }),
+      (effect) => circuitBreaker.withCircuitBreaker(strategy.id, effect),
+      (effect) => requestPool.withPoolManagement(params.chainId, effect),
+      Effect.flatMap((data) => (data instanceof MissingMetaError ? Effect.fail(data) : Effect.succeed(data))),
     )
   }