Merge pull request #43 from 3n3a-school/add-edit-test

remove visibility test

Author: lnstuder

.github/workflows/ci.yml

@@ -45,7 +45,11 @@ jobs:
         cd ./assets
         npm install
     
-    - name: run cypress
-      run: |
-        chmod +x ./cypress-run.sh
-        sh ./cypress-run.sh
+    - name: run headless test
+      uses: GabrielBB/xvfb-action@v1
+      with:
+        run: |
+          chmod +x ./cypress-run.sh
+          sh ./cypress-run.sh
+        working-directory: ./
+    

cypress-run.sh

@@ -8,7 +8,7 @@ echo "===RUN npm install cypress --save-dev ==="
 echo "===IN THE assets/ FOLDER==="
 MIX_ENV=test mix phx.server &
 pid=$! # Store server pid
-./assets/node_modules/.bin/cypress run
+./assets/node_modules/.bin/cypress run --headed
 result=$?
 kill -9 $pid # kill server
 echo "===KILLING PHX SERVER==="

lib/m307_web/templates/loan/index.html.heex

@@ -1,9 +1,9 @@
 <h1>Listing Loans</h1>
 
-<span><%= link "New Loan", to: Routes.loan_path(@conn, :new) %></span>
+<span><%= link "New Loan", to: Routes.loan_path(@conn, :new), id: "new_loan_btn" %></span>
 
 <div class="table-responsive">
-  <table class="table">
+  <table class="table" id="loan_table">
     <thead>
       <tr>
         <th>Name</th>

test/cypress/integration/index.spec.js

@@ -8,25 +8,25 @@ describe('Integration Test', () => {
     it('should create a loan', () => {
         cy.visit(URL)
 
-        cy.get("body > div > main > span > a").click()
+        cy.get("#new_loan_btn").click()
         cy.get("#loan_name").type("New House")
         cy.get("#loan_email").type("max.muster@css.ch")
         cy.get("#loan_phone").type("+411234202030")
         cy.get("#loan_rate_count").type("7")
         cy.get("#loan_credit_package").select("8")
-        cy.get("body > div > main > form > div").should('be.visible')
+        //cy.get("body > div > main > form > div").should('be.visible')
         cy.get("button[type=submit]").click()
         cy.visit(URL)
-        cy.get("body > div > main > table > tbody").children().should("have.length", 1)
+        cy.get("#loan_table > tbody").children().should("have.length", 1)
     })
 
     it('should edit a loan', () => {
         cy.visit(URL)
 
-        cy.get("body > div > main > table > tbody > tr > td:nth-child(8) > span:nth-child(2) > a").click()
+        cy.get("#loan_table > tbody > tr > td:nth-child(8) > span:nth-child(2) > a").click()
         cy.get("#loan_email").clear().type("max.muster@suva.ch")
         cy.get("button[type=submit]").click()
         cy.visit(URL)
-        cy.get("body > div > main > table > tbody > tr > td:nth-child(2)").should("have.text", "max.muster@suva.ch")
+        cy.get("#loan_table > tbody > tr > td:nth-child(2)").should("have.text", "max.muster@suva.ch")
     })
-})
+})