Rename method to avoid confusion

Author: vovannikov

src/fsi/src/partitioned/model_evaluator/4C_fsi_str_model_evaluator_partitioned.cpp

@@ -122,7 +122,7 @@ Solid::ModelEvaluator::PartitionedFSI::solve_relaxation_linear(
       const_cast<Solid::Nln::SOLVER::Generic&>(*(ti_impl->get_nln_solver_ptr()));
 
   // get the solution group
-  ::NOX::Abstract::Group& grp = nlnsolver.solution_group();
+  ::NOX::Abstract::Group& grp = nlnsolver.get_solution_group();
   NOX::Nln::Group* grp_ptr = dynamic_cast<NOX::Nln::Group*>(&grp);
   if (grp_ptr == nullptr) FOUR_C_THROW("Dynamic cast failed!");
 

src/structure_new/src/explicit/4C_structure_new_timint_explicit.cpp

@@ -109,7 +109,7 @@ void Solid::TimeInt::Explicit::evaluate()
 {
   check_init_setup();
   throw_if_state_not_in_sync_with_nox_group();
-  ::NOX::Abstract::Group& grp = nln_solver().solution_group();
+  ::NOX::Abstract::Group& grp = nln_solver().get_solution_group();
 
   auto* grp_ptr = dynamic_cast<NOX::Nln::Group*>(&grp);
   if (grp_ptr == nullptr) FOUR_C_THROW("Dynamic cast failed!");

src/structure_new/src/implicit/4C_structure_new_timint_implicit.cpp

@@ -84,7 +84,7 @@ void Solid::TimeInt::Implicit::set_state(const std::shared_ptr<Core::LinAlg::Vec
   integrator_ptr()->set_state(*x);
   ::NOX::Epetra::Vector x_nox(
       Teuchos::rcpFromRef(*x->get_ptr_of_epetra_vector()), ::NOX::Epetra::Vector::CreateView);
-  nln_solver().solution_group().setX(x_nox);
+  nln_solver().get_solution_group().setX(x_nox);
   set_state_in_sync_with_nox_group(true);
 }
 
@@ -109,7 +109,7 @@ void Solid::TimeInt::Implicit::prepare_time_step()
   double& time_np = data_global_state().get_time_np();
   time_np = data_global_state().get_time_n() + (*data_global_state().get_delta_time())[0]; */
 
-  ::NOX::Abstract::Group& grp = nln_solver().solution_group();
+  ::NOX::Abstract::Group& grp = nln_solver().get_solution_group();
   predictor().predict(grp);
 }
 
@@ -130,7 +130,7 @@ int Solid::TimeInt::Implicit::integrate_step()
 {
   check_init_setup();
   // do the predictor step
-  ::NOX::Abstract::Group& grp = nln_solver().solution_group();
+  ::NOX::Abstract::Group& grp = nln_solver().get_solution_group();
   predictor().predict(grp);
   return solve();
 }
@@ -158,7 +158,7 @@ void Solid::TimeInt::Implicit::update_state_incrementally(
 
   check_init_setup();
   throw_if_state_not_in_sync_with_nox_group();
-  ::NOX::Abstract::Group& grp = nln_solver().solution_group();
+  ::NOX::Abstract::Group& grp = nln_solver().get_solution_group();
 
   auto* grp_ptr = dynamic_cast<NOX::Nln::Group*>(&grp);
   FOUR_C_ASSERT(grp_ptr != nullptr, "Dynamic cast failed!");
@@ -202,7 +202,7 @@ void Solid::TimeInt::Implicit::evaluate()
 {
   check_init_setup();
   throw_if_state_not_in_sync_with_nox_group();
-  ::NOX::Abstract::Group& grp = nln_solver().solution_group();
+  ::NOX::Abstract::Group& grp = nln_solver().get_solution_group();
 
   auto* grp_ptr = dynamic_cast<NOX::Nln::Group*>(&grp);
   FOUR_C_ASSERT(grp_ptr != nullptr, "Dynamic cast failed!");

src/structure_new/src/nonlinear_solver/4C_structure_new_nln_solver_generic.cpp

@@ -70,7 +70,10 @@ ::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::group()
 
 /*----------------------------------------------------------------------------*
  *----------------------------------------------------------------------------*/
-::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::solution_group() { return group(); }
+::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::get_solution_group()
+{
+  return group();
+}
 
 /*----------------------------------------------------------------------------*
  *----------------------------------------------------------------------------*/

src/structure_new/src/nonlinear_solver/4C_structure_new_nln_solver_generic.hpp

@@ -81,7 +81,7 @@ namespace Solid
          *
          *  The nox group has to be initialized in one of the derived setup() routines beforehand.
          */
-        ::NOX::Abstract::Group& solution_group();
+        ::NOX::Abstract::Group& get_solution_group();
         const ::NOX::Abstract::Group& get_solution_group() const;
 
         //! Get the number of nonlinear iterations